You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by misakuo <gi...@git.apache.org> on 2017/03/27 12:01:57 UTC
[GitHub] incubator-weex pull request #172: * [android] allow 0 as width or height for...
GitHub user misakuo opened a pull request:
https://github.com/apache/incubator-weex/pull/172
* [android] allow 0 as width or height for view
Testcase:
http://dotwe.org/weex/61bdb15864bf581904a280cedcd3681b
iOS & H5 are currently in line with expectations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/misakuo/incubator-weex android-bugfix-zero-height
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #172
----
commit 7f606216b1b6239749c56100d65f1d067ff9e9fd
Author: moxun.ljf <mo...@alibaba-inc.com>
Date: 2017-03-23T05:45:38Z
* [example] add demo for list & scroller with onScroll event
commit 9076095f84cbc8b886ecba10ec8a74d70ad92d8e
Author: moxun.ljf <fu...@foxmail.com>
Date: 2017-03-27T02:53:23Z
Merge remote-tracking branch 'upstream/0.12-dev' into 0.12-dev
commit e7656e791af8da09bb39c8f96af4e00daa6ad1d2
Author: moxun.ljf <fu...@foxmail.com>
Date: 2017-03-27T11:46:10Z
Merge remote-tracking branch 'upstream/0.12-dev' into 0.12-dev
commit 1845031541edf192625474dccc827cb0a4c7b3b4
Author: moxun.ljf <fu...@foxmail.com>
Date: 2017-03-27T11:57:58Z
* [android] accept 0 value as height or width
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #172: * [android] allow 0 as width or height for view
Posted by misakuo <gi...@git.apache.org>.
Github user misakuo commented on the issue:
https://github.com/apache/incubator-weex/pull/172
ok, you can close this pr after csslayout updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #172: * [android] allow 0 as width or height for view
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on the issue:
https://github.com/apache/incubator-weex/pull/172
Maybe we should open a new thread in mailing list to discuss about layout upgrading.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #172: * [android] allow 0 as width or height for...
Posted by misakuo <gi...@git.apache.org>.
Github user misakuo closed the pull request at:
https://github.com/apache/incubator-weex/pull/172
---
[GitHub] incubator-weex issue #172: * [android] allow 0 as width or height for view
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/172
Agreed. Let's discuss yoga upgrading in dev@
On Fri, Mar 31, 2017 at 4:38 PM, \u9690\u5c0f\u98ce <no...@github.com> wrote:
> Maybe we should open a new thread in mailing list to discuss about layout
> upgrading.
>
> \u2014
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-weex/pull/172#issuecomment-290652401>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAHCAR--BLoVP5k3bnvVp4G99jlzv-LEks5rrLuVgaJpZM4MqKzZ>
> .
>
--
sospartan
Phone:13588488290
HangZhou
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #172: * [android] allow 0 as width or height for view
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/172
We do not modify csslayout directly. And we will update new version later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---