You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Kathey Marsden <km...@sbcglobal.net> on 2011/01/05 19:13:18 UTC

Backporting 764912

When backporting DERBY-4913 to 10.5 I hit a conflict because of this change:

http://svn.apache.org/viewvc?view=revision&revision=764912

$ svn log -c 764912
------------------------------------------------------------------------
r764912 | rhillegas | 2009-04-14 11:23:15 -0700 (Tue, 14 Apr 2009) | 1 line

-d
------------------------------------------------------------------------

Myrna helped me track it as part of  DERBY-4157  and Iooks like  a code 
refactor...
Attaching derby-4157-01-aa-refactor.diff. This patch is a first step 
toward writing the new test. This patch factors out some of the existing 
upgrade test machinery so that the new test can re-use that machinery:

1) logic to discover old versions
2) logic to create class loaders out of those old versions
3) logic to use those class loaders

Does anyone see any issues with backporting just this part of DERBY-4157?

Thanks

Kathey



Re: Backporting 764912

Posted by Kathey Marsden <km...@sbcglobal.net>.
On 1/5/2011 10:31 AM, Rick Hillegas wrote:
> Hi Kathey,
>
> I think it should be safe to backport this refactoring.
Thanks Rick for the prompt response. It merged cleanly and I submitted 
to 10.5 with revision 105585




Re: Backporting 764912

Posted by Rick Hillegas <ri...@oracle.com>.
Hi Kathey,

I think it should be safe to backport this refactoring.

Regards,
-Rick

On 1/5/11 10:13 AM, Kathey Marsden wrote:
> When backporting DERBY-4913 to 10.5 I hit a conflict because of this 
> change:
>
> http://svn.apache.org/viewvc?view=revision&revision=764912
>
> $ svn log -c 764912
> ------------------------------------------------------------------------
> r764912 | rhillegas | 2009-04-14 11:23:15 -0700 (Tue, 14 Apr 2009) | 1 
> line
>
> -d
> ------------------------------------------------------------------------
>
> Myrna helped me track it as part of  DERBY-4157  and Iooks like  a 
> code refactor...
> Attaching derby-4157-01-aa-refactor.diff. This patch is a first step 
> toward writing the new test. This patch factors out some of the 
> existing upgrade test machinery so that the new test can re-use that 
> machinery:
>
> 1) logic to discover old versions
> 2) logic to create class loaders out of those old versions
> 3) logic to use those class loaders
>
> Does anyone see any issues with backporting just this part of DERBY-4157?
>
> Thanks
>
> Kathey
>
>
>