You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/10 18:19:44 UTC

[GitHub] [maven-dependency-analyzer] ian-lavallee commented on a change in pull request #14: [MDEP-708] - dependency:analyze recommends test scope for test-only artifacts that have non-test scope

ian-lavallee commented on a change in pull request #14:
URL: https://github.com/apache/maven-dependency-analyzer/pull/14#discussion_r453001178



##########
File path: src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java
##########
@@ -189,6 +210,29 @@ else if ( file != null && file.isDirectory() )
         return artifactClassMap;
     }
 
+    protected Set<String> buildTestDependencyClasses( MavenProject project ) throws IOException

Review comment:
       All the other buildMethod methods are protected so I made this protected to keep it the same




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org