You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/22 18:17:50 UTC

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11484: [BEAM-9778] remove temp directory & add docker-pull-licenses to release scripts

Hannah-Jiang commented on a change in pull request #11484:
URL: https://github.com/apache/beam/pull/11484#discussion_r413211860



##########
File path: sdks/java/container/build.gradle
##########
@@ -94,8 +86,12 @@ licenseReport {
 task copyThirdPartyLicenses(type: Copy) {
   from ("third_party_licenses")
   into "build/target/third_party_licenses"
+  doLast {
+    file('third_party_licenses').deleteDir()
+  }
 }
 
+def Boolean pull_licenses

Review comment:
       when we pass `docker-pull-licenses` to `:sdks:java:container:docker`, `generateThirdPartyLicenses` task doesn't understand it. In order to pass the tag from docker task to `generateThirdPartyLicenses`, we need a global value to share it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org