You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/10/07 03:10:19 UTC
[PR] [SPARK-45446][PYTHON] Fix imports according to PEP8: pyspark.errors and pyspark.ml [spark]
HyukjinKwon opened a new pull request, #43255:
URL: https://github.com/apache/spark/pull/43255
### What changes were proposed in this pull request?
This PR proposes to fix imports according to PEP8 in `pyspark.errors` and `pyspark.ml`, see https://peps.python.org/pep-0008/#imports.
### Why are the changes needed?
I have not been fixing them as they are too minor. However, this practice is being propagated across the whole PySpark packages, and I think we should fix them all so other users do not follow the non-standard practice.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing linters and tests should cover.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45446][PYTHON] Fix imports according to PEP8: pyspark.errors and pyspark.ml [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43255:
URL: https://github.com/apache/spark/pull/43255#issuecomment-1751586873
cc @itholic @zhengruifeng @WeichenXu123 fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45446][PYTHON] Fix imports according to PEP8: pyspark.errors and pyspark.ml [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43255: [SPARK-45446][PYTHON] Fix imports according to PEP8: pyspark.errors and pyspark.ml
URL: https://github.com/apache/spark/pull/43255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org