You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2026/03/09 12:56:23 UTC

[PR] chore(extensions): bump superset-core and superset-extensions-cli to 0.1.0rc1 [superset]

michael-s-molina opened a new pull request, #38516:
URL: https://github.com/apache/superset/pull/38516

   ### SUMMARY
   
   Bumps all extension packages from their `0.0.x` release candidates to `0.1.0rc1`, marking the first minor version milestone:
   
   | Package | Before | After |
   |---|---|---|
   | `apache-superset-core` (Python) | `0.0.1rc4` | `0.1.0rc1` |
   | `apache-superset-extensions-cli` | `0.0.1rc2` | `0.1.0rc1` |
   | `@apache-superset/core` (npm) | `0.0.1-rc11` | `0.1.0-rc1` |
   
   Also updates the READMEs for both packages to reflect the current state of the code (command signatures, available decorators, package structure).
   
   ### TESTING INSTRUCTIONS
   
   1. Verify version fields in `superset-core/pyproject.toml`, `superset-extensions-cli/pyproject.toml`, and `superset-frontend/packages/superset-core/package.json`
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] chore(extensions): bump superset-core and superset-extensions-cli to 0.1.0rc1 [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #38516:
URL: https://github.com/apache/superset/pull/38516#discussion_r2906294845


##########
superset-core/README.md:
##########
@@ -31,83 +31,78 @@ The official core package for building Apache Superset backend extensions and in
 pip install apache-superset-core
 ```
 
-## πŸ—οΈ Architecture
+## πŸ—οΈ Package Structure
 
-The package is organized into logical modules, each providing specific functionality:
-
-- **`api`** - REST API base classes, models access, query utilities, and registration
-- **`api.models`** - Access to Superset's database models (datasets, databases, etc.)
-- **`api.query`** - Database query utilities and SQL dialect handling
-- **`api.rest_api`** - Extension API registration and management
-- **`api.types.rest_api`** - REST API base classes and type definitions
+```
+src/superset_core/
+β”œβ”€β”€ common/
+β”œβ”€β”€ extensions/
+β”œβ”€β”€ mcp/
+β”œβ”€β”€ queries/
+β”œβ”€β”€ rest_api/
+β”œβ”€β”€ tasks/
+└── __init__.py
+```
 
 ## πŸš€ Quick Start
 
-### Basic Extension Structure
+### Basic Extension API
 
 ```python
-from flask import request, Response
 from flask_appbuilder.api import expose, permission_name, protect, safe
-from superset_core import common, queries, rest_api
 from superset_core.rest_api.api import RestApi
+from superset_core.rest_api.decorators import api
 
-class DatasetReferencesAPI(RestApi):
-    """Example extension API demonstrating core functionality."""
 
+@api(id="dataset_references", name="Dataset References API")
+class DatasetReferencesAPI(RestApi):
     resource_name = "dataset_references"
-    openapi_spec_tag = "Dataset references"
-    class_permission_name = "dataset_references"

Review Comment:
   You can also remove `resource_name`, as the optional `resource_name` parameter should be passed in the `@api` decorator.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] chore(extensions): bump superset-core and superset-extensions-cli to 0.1.0rc1 [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #38516:
URL: https://github.com/apache/superset/pull/38516#issuecomment-4023578422

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/38516?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 65.00%. Comparing base ([`a6c0d63`](https://app.codecov.io/gh/apache/superset/commit/a6c0d6321f646753a4274bf152ef4bba5dad42b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5c20b89`](https://app.codecov.io/gh/apache/superset/commit/5c20b89d18b22742f432f077e83438b499f94cb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   :x: Your project check has failed because the head coverage (99.24%) is below the target coverage (100.00%). You can increase the head coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #38516      +/-   ##
   ==========================================
   + Coverage   64.82%   65.00%   +0.17%     
   ==========================================
     Files        1817     1822       +5     
     Lines       72121    72642     +521     
     Branches    22955    22955              
   ==========================================
   + Hits        46754    47221     +467     
   - Misses      25367    25421      +54     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/38516/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ” | |
   |---|---|---|
   | [superset-extensions-cli](https://app.codecov.io/gh/apache/superset/pull/38516/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.63% <ΓΈ> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/38516?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] chore(extensions): bump superset-core and superset-extensions-cli to 0.1.0rc1 [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38516:
URL: https://github.com/apache/superset/pull/38516#issuecomment-4023564607

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] chore(extensions): bump superset-core and superset-extensions-cli to 0.1.0rc1 [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #38516:
URL: https://github.com/apache/superset/pull/38516


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] chore(extensions): bump superset-core and superset-extensions-cli to 0.1.0rc1 [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #38516:
URL: https://github.com/apache/superset/pull/38516#discussion_r2906559016


##########
superset-core/README.md:
##########
@@ -31,83 +31,78 @@ The official core package for building Apache Superset backend extensions and in
 pip install apache-superset-core
 ```
 
-## πŸ—οΈ Architecture
+## πŸ—οΈ Package Structure
 
-The package is organized into logical modules, each providing specific functionality:
-
-- **`api`** - REST API base classes, models access, query utilities, and registration
-- **`api.models`** - Access to Superset's database models (datasets, databases, etc.)
-- **`api.query`** - Database query utilities and SQL dialect handling
-- **`api.rest_api`** - Extension API registration and management
-- **`api.types.rest_api`** - REST API base classes and type definitions
+```
+src/superset_core/
+β”œβ”€β”€ common/
+β”œβ”€β”€ extensions/
+β”œβ”€β”€ mcp/
+β”œβ”€β”€ queries/
+β”œβ”€β”€ rest_api/
+β”œβ”€β”€ tasks/
+└── __init__.py
+```
 
 ## πŸš€ Quick Start
 
-### Basic Extension Structure
+### Basic Extension API
 
 ```python
-from flask import request, Response
 from flask_appbuilder.api import expose, permission_name, protect, safe
-from superset_core import common, queries, rest_api
 from superset_core.rest_api.api import RestApi
+from superset_core.rest_api.decorators import api
 
-class DatasetReferencesAPI(RestApi):
-    """Example extension API demonstrating core functionality."""
 
+@api(id="dataset_references", name="Dataset References API")
+class DatasetReferencesAPI(RestApi):
     resource_name = "dataset_references"
-    openapi_spec_tag = "Dataset references"
-    class_permission_name = "dataset_references"

Review Comment:
   Removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org