You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/08/29 08:55:39 UTC
[jira] [Commented] (HBASE-4269) Add tests and restore semantics to
TableInputFormat/TableRecordReader
[ https://issues.apache.org/jira/browse/HBASE-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092667#comment-13092667 ]
jiraposter@reviews.apache.org commented on HBASE-4269:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1675/#review1675
-----------------------------------------------------------
Nice work.
src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java
<https://reviews.apache.org/r/1675/#comment3823>
Please add javadoc stating that this test covers org.apache.hadoop.hbase.mapred namespace.
src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java
<https://reviews.apache.org/r/1675/#comment3826>
I think calling implementation class' ctor is better, following example of runTestMapreduce().
src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java
<https://reviews.apache.org/r/1675/#comment3824>
Please add javadoc stating that this test covers org.apache.hadoop.hbase.mapreduce namespace.
src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java
<https://reviews.apache.org/r/1675/#comment3825>
Please wrap long line.
- Ted
On 2011-08-29 04:20:16, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1675/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-29 04:20:16)
bq.
bq.
bq. Review request for hbase, Ted Yu and Ming Ma.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. commit d2bbee8696d54245b046158bacb5ab1a210e5df6
bq. Author: Jonathan Hsieh <jo...@cloudera.com>
bq. Date: Sun Aug 28 19:10:57 2011 -0700
bq.
bq. HBASE-4269: Add tests and restore semantics to TableImportFormat/TableRecordReader
bq.
bq. Adding tests cases and restoring sematics from HBASE-4196 patch.
bq.
bq.
bq. This addresses bug HBASE-4269.
bq. https://issues.apache.org/jira/browse/HBASE-4269
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReaderImpl.java 54df2cf
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java c5fc496
bq. src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/1675/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. New unit tests pass, running other tests.
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> Add tests and restore semantics to TableInputFormat/TableRecordReader
> ---------------------------------------------------------------------
>
> Key: HBASE-4269
> URL: https://issues.apache.org/jira/browse/HBASE-4269
> Project: HBase
> Issue Type: Improvement
> Components: mapred, mapreduce, test
> Affects Versions: 0.92.0, 0.90.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.5
>
> Attachments: 0001-HBASE-4269-Add-tests-and-restore-semantics-to-TableI.patch
>
>
> HBASE-4196 Modified the semantics of failures in TableImportFormat/TableRecordReader, and had no tests cases. This patch restores semantics to rethrow when a DoNotRetryIOException is triggered and adds test cases.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira