Re: [PR] Make Topk aggregate tests deterministic [arrow-datafusion]

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #8998:
URL: https://github.com/apache/arrow-datafusion/pull/8998#discussion_r1466636695


##########
datafusion/sqllogictest/test_files/aggregates_topk.slt:
##########
@@ -26,8 +26,8 @@ CREATE TABLE traces(trace_id varchar, timestamp bigint, other bigint) AS VALUES
 ('a', NULL, NULL),
 ('a', 1, 1),
 ('a', -1, -1),
-('b', 0, 0),
-('c', 1, 1),
+('b', -2, 0),

Review Comment:
   Maybe add some rows with a duplicate timestamp to address @avantgardnerio 's comment?
   
   Perhaps something lke
   
   ```
   ('c', 4, 10),
   ('c', 2, 10),
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org