You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by kinow <gi...@git.apache.org> on 2017/10/30 10:59:54 UTC
[GitHub] lucene-solr pull request #268: Fix some spell check issues
GitHub user kinow opened a pull request:
https://github.com/apache/lucene-solr/pull/268
Fix some spell check issues
A few spell check issues in Javadoc and one in the HTML guide.
Bruno
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kinow/lucene-solr fix-spell-check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #268
----
commit a8368a370c78d8ccd1b8c4cf8208b11cb14cf556
Author: Bruno P. Kinoshita <br...@yahoo.com.br>
Date: 2017-10-30T10:57:52Z
Fix some spell check issues
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #268: Fix some spell check issues
Posted by iorixxx <gi...@git.apache.org>.
Github user iorixxx commented on the issue:
https://github.com/apache/lucene-solr/pull/268
*TokenizerImpl.java files have corresponding *.jflex files in the source tree. Do you mind fixing typos in *.jflex files? I think the ant target `ant jflex` in `lucene/analysis/common/` is used to generate *.java files from *.jflex files.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #268: Fix some spell check issues
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/lucene-solr/pull/268
Sure @iorixxx
Let's see if I didn't miss anything. So first I found the *TokenizerImpl.java files with `git diff --name-only HEAD~1 | grep TokenizerImpl`
```
lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/ClassicTokenizerImpl.java
lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/UAX29URLEmailTokenizerImpl.java
lucene/analysis/common/src/java/org/apache/lucene/analysis/wikipedia/WikipediaTokenizerImpl.java
lucene/core/src/java/org/apache/lucene/analysis/standard/StandardTokenizerImpl.java
```
Then use the file from GitHub master branch.
```
git diff --name-only HEAD~1 | grep TokenizerImpl | xargs -I{} git checkout origin/master {}
git add .
git commit -m "Will be rebased..."
git rebase -i HEAD~2
# mark with f the "Will be rebased commit"
```
And now `git diff --name-only HEAD~1 | grep TokenizerImpl` gives me an empty result.
Confirm I have the jflex files:
```
$git diff --name-only origin/fix-spell-check | xargs -I{} basename {} .java | xargs -I{} find . -name "{}*"
./lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/ClassicTokenizerImpl.jflex
./lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/ClassicTokenizerImpl.java
./lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/UAX29URLEmailTokenizerImpl.java
./lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/UAX29URLEmailTokenizerImpl.jflex
./lucene/analysis/common/src/java/org/apache/lucene/analysis/wikipedia/WikipediaTokenizerImpl.jflex
./lucene/analysis/common/src/java/org/apache/lucene/analysis/wikipedia/WikipediaTokenizerImpl.java
./lucene/core/src/java/org/apache/lucene/analysis/standard/StandardTokenizerImpl.jflex
./lucene/core/src/java/org/apache/lucene/analysis/standard/StandardTokenizerImpl.java
```
Then get the diff (`git diff --patch origin/fix-spell-check `).... and trying to apply the Java changes to jflex files now... except that... there's no "**occured**" on these jflex files...
After a bit of searching here and there, and reading a bit about jflex (had never heard about it, good to learn something new), looks like the typo is actually in jflex's code.
https://github.com/jflex-de/jflex/pull/218
Going to push-force the commit that removes the *TokenizerImpl.java files.
Does it make sense? Did I miss something?
Cheers
Bruno
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org