You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/17 09:53:23 UTC
[GitHub] [airflow] mik-laj opened a new pull request #14846: Optimize docs build for new packages
mik-laj opened a new pull request #14846:
URL: https://github.com/apache/airflow/pull/14846
New packages are prioritized because they have no inventory, which causes all other builds to fail.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14846: Create a documentation package for Docker image
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14846:
URL: https://github.com/apache/airflow/pull/14846#discussion_r596813056
##########
File path: docs/apache-airflow/production-deployment.rst
##########
@@ -118,852 +118,7 @@ To mitigate these issues, make sure you have a :doc:`health check </logging-moni
Production Container Images
===========================
-Production-ready reference Image
Review comment:
This page still exists, so we can't redirect the user. Instead of old content with multiple sections, we now have one section with a link to the new package.
<img width="1412" alt="Screenshot 2021-03-18 at 13 17 05" src="https://user-images.githubusercontent.com/12058428/111624672-44215980-87ec-11eb-8c6c-f890894a024b.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14846: Optimize docs build for new packages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14846:
URL: https://github.com/apache/airflow/pull/14846#issuecomment-801423053
[The Workflow run](https://github.com/apache/airflow/actions/runs/662366525) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #14846: Create a documentation package for Docker image
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #14846:
URL: https://github.com/apache/airflow/pull/14846#issuecomment-801827463
New documentation package for Docker Image has been reverted https://github.com/apache/airflow/pull/14867. So I am adding it again in this change.
CC: @kaxil @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #14846: Create a documentation package for Docker image
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #14846:
URL: https://github.com/apache/airflow/pull/14846#issuecomment-803493554
@kaxil Ci are green. Can you look at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #14846: Create a documentation package for Docker image
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14846:
URL: https://github.com/apache/airflow/pull/14846#discussion_r596784404
##########
File path: docs/apache-airflow/production-deployment.rst
##########
@@ -118,852 +118,7 @@ To mitigate these issues, make sure you have a :doc:`health check </logging-moni
Production Container Images
===========================
-Production-ready reference Image
Review comment:
Do we have a redirect for this page to the new location?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #14846: Create a documentation package for Docker image
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #14846:
URL: https://github.com/apache/airflow/pull/14846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14846: Optimize docs build for new packages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14846:
URL: https://github.com/apache/airflow/pull/14846#issuecomment-800949083
[The Workflow run](https://github.com/apache/airflow/actions/runs/660624733) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14846: Optimize docs build for new packages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14846:
URL: https://github.com/apache/airflow/pull/14846#issuecomment-800987199
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14846: Create a documentation package for Docker image
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14846:
URL: https://github.com/apache/airflow/pull/14846#discussion_r596813056
##########
File path: docs/apache-airflow/production-deployment.rst
##########
@@ -118,852 +118,7 @@ To mitigate these issues, make sure you have a :doc:`health check </logging-moni
Production Container Images
===========================
-Production-ready reference Image
Review comment:
This page still exists, so we can't redirect the user. Instead of old content with multiple sections, we now have one section with an incentive with a link to the new package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #14846: Create a documentation package for Docker image
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #14846:
URL: https://github.com/apache/airflow/pull/14846#issuecomment-803493554
@kaxil Ci are green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org