You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Manuel Teira (JIRA)" <qp...@incubator.apache.org> on 2008/06/11 13:26:45 UTC
[jira] Created: (QPID-1131) Refactor cpp/examples directory to be
build under autotools
Refactor cpp/examples directory to be build under autotools
-----------------------------------------------------------
Key: QPID-1131
URL: https://issues.apache.org/jira/browse/QPID-1131
Project: Qpid
Issue Type: Improvement
Components: Qpid Examples
Affects Versions: M3
Environment: Any
Reporter: Manuel Teira
Priority: Minor
Fix For: M3
Using ad-hoc makefiles for example generation and doesn't seem the best way to go, since autotools machinery is avoided, and they don't generate in all circunstances.
I've changed it to use autotools, and to generate a proper simple staging Makefile, as expected.
Also included is the refactoring of the directory hierarchy, unfortunately I'm not able to generate a proper patch since directories were moved, so, I'm including the whole procedure:
(Some of the svn ops need to be forced):
cd cpp/examples
# Remove the current Makefiles, as they will be generated using autotools
svn remove examples/Makefile
svn remove examples/direct/Makefile
svn remove examples/fanout/Makefile
svn remove examples/pub-sub/Makefile
svn remove examples/request-response/Makefile
svn remove examples/xml-exchange/Makefile
# Bring the examples to the current directory
svn move README README.verify
svn move examples/README README
svn move examples/direct .
svn move examples/fanout .
svn move examples/pub-sub .
svn move examples/xml-exchange .
#After applying the attached patch
#Add autotools machinery
svn add makedist.mk
svn add examples/direct/Makefile.am
svn add examples/fanout/Makefile.am
svn add examples/pub-sub/Makefile.am
svn add examples/request-response/Makefile.am
svn add examples/xml-exchange/Makefile.am
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1131) Refactor cpp/examples directory to be
build under autotools
Posted by "Alan Conway (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Conway resolved QPID-1131.
-------------------------------
Resolution: Fixed
Comitted in revision 670066.
I added some fixes for VPATH builds and make distcheck - the examples were the main roadblock to getting make distcheck to work before.
Thanks Manuel!
> Refactor cpp/examples directory to be build under autotools
> -----------------------------------------------------------
>
> Key: QPID-1131
> URL: https://issues.apache.org/jira/browse/QPID-1131
> Project: Qpid
> Issue Type: Improvement
> Components: Qpid Examples
> Affects Versions: M3
> Environment: Any
> Reporter: Manuel Teira
> Assignee: Alan Conway
> Priority: Minor
> Fix For: M3
>
> Attachments: examples.patch
>
>
> Using ad-hoc makefiles for example generation and doesn't seem the best way to go, since autotools machinery is avoided, and they don't generate in all circunstances.
> I've changed it to use autotools, and to generate a proper simple staging Makefile, as expected.
> Also included is the refactoring of the directory hierarchy, unfortunately I'm not able to generate a proper patch since directories were moved, so, I'm including the whole procedure:
> (Some of the svn ops need to be forced):
> cd cpp/examples
> # Remove the current Makefiles, as they will be generated using autotools
> svn remove examples/Makefile
> svn remove examples/direct/Makefile
> svn remove examples/fanout/Makefile
> svn remove examples/pub-sub/Makefile
> svn remove examples/request-response/Makefile
> svn remove examples/xml-exchange/Makefile
> # Bring the examples to the current directory
> svn move README README.verify
> svn move examples/README README
> svn move examples/direct .
> svn move examples/fanout .
> svn move examples/pub-sub .
> svn move examples/xml-exchange .
> #After applying the attached patch
> #Add autotools machinery
> svn add makedist.mk
> svn add examples/direct/Makefile.am
> svn add examples/fanout/Makefile.am
> svn add examples/pub-sub/Makefile.am
> svn add examples/request-response/Makefile.am
> svn add examples/xml-exchange/Makefile.am
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1131) Refactor cpp/examples directory to be
build under autotools
Posted by "Manuel Teira (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607168#action_12607168 ]
Manuel Teira commented on QPID-1131:
------------------------------------
I think the examples/Makefile was not svn deleted, shouldn't it be?
> Refactor cpp/examples directory to be build under autotools
> -----------------------------------------------------------
>
> Key: QPID-1131
> URL: https://issues.apache.org/jira/browse/QPID-1131
> Project: Qpid
> Issue Type: Improvement
> Components: Qpid Examples
> Affects Versions: M3
> Environment: Any
> Reporter: Manuel Teira
> Assignee: Alan Conway
> Priority: Minor
> Fix For: M3
>
> Attachments: examples.patch
>
>
> Using ad-hoc makefiles for example generation and doesn't seem the best way to go, since autotools machinery is avoided, and they don't generate in all circunstances.
> I've changed it to use autotools, and to generate a proper simple staging Makefile, as expected.
> Also included is the refactoring of the directory hierarchy, unfortunately I'm not able to generate a proper patch since directories were moved, so, I'm including the whole procedure:
> (Some of the svn ops need to be forced):
> cd cpp/examples
> # Remove the current Makefiles, as they will be generated using autotools
> svn remove examples/Makefile
> svn remove examples/direct/Makefile
> svn remove examples/fanout/Makefile
> svn remove examples/pub-sub/Makefile
> svn remove examples/request-response/Makefile
> svn remove examples/xml-exchange/Makefile
> # Bring the examples to the current directory
> svn move README README.verify
> svn move examples/README README
> svn move examples/direct .
> svn move examples/fanout .
> svn move examples/pub-sub .
> svn move examples/xml-exchange .
> #After applying the attached patch
> #Add autotools machinery
> svn add makedist.mk
> svn add examples/direct/Makefile.am
> svn add examples/fanout/Makefile.am
> svn add examples/pub-sub/Makefile.am
> svn add examples/request-response/Makefile.am
> svn add examples/xml-exchange/Makefile.am
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1131) Refactor cpp/examples directory to be
build under autotools
Posted by "Alan Conway (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Conway reassigned QPID-1131:
---------------------------------
Assignee: Alan Conway
> Refactor cpp/examples directory to be build under autotools
> -----------------------------------------------------------
>
> Key: QPID-1131
> URL: https://issues.apache.org/jira/browse/QPID-1131
> Project: Qpid
> Issue Type: Improvement
> Components: Qpid Examples
> Affects Versions: M3
> Environment: Any
> Reporter: Manuel Teira
> Assignee: Alan Conway
> Priority: Minor
> Fix For: M3
>
> Attachments: examples.patch
>
>
> Using ad-hoc makefiles for example generation and doesn't seem the best way to go, since autotools machinery is avoided, and they don't generate in all circunstances.
> I've changed it to use autotools, and to generate a proper simple staging Makefile, as expected.
> Also included is the refactoring of the directory hierarchy, unfortunately I'm not able to generate a proper patch since directories were moved, so, I'm including the whole procedure:
> (Some of the svn ops need to be forced):
> cd cpp/examples
> # Remove the current Makefiles, as they will be generated using autotools
> svn remove examples/Makefile
> svn remove examples/direct/Makefile
> svn remove examples/fanout/Makefile
> svn remove examples/pub-sub/Makefile
> svn remove examples/request-response/Makefile
> svn remove examples/xml-exchange/Makefile
> # Bring the examples to the current directory
> svn move README README.verify
> svn move examples/README README
> svn move examples/direct .
> svn move examples/fanout .
> svn move examples/pub-sub .
> svn move examples/xml-exchange .
> #After applying the attached patch
> #Add autotools machinery
> svn add makedist.mk
> svn add examples/direct/Makefile.am
> svn add examples/fanout/Makefile.am
> svn add examples/pub-sub/Makefile.am
> svn add examples/request-response/Makefile.am
> svn add examples/xml-exchange/Makefile.am
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1131) Refactor cpp/examples directory to be
build under autotools
Posted by "Manuel Teira (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manuel Teira updated QPID-1131:
-------------------------------
Attachment: examples.patch
Patch including:
New Makefile.am for the examples directory
New Makefile.am files for all the examples
makedist.mk to generate the distributed makefiles
Added the new Makefiles to be generated to configure.ac
Some bashisms deleted from verify and verify_all
> Refactor cpp/examples directory to be build under autotools
> -----------------------------------------------------------
>
> Key: QPID-1131
> URL: https://issues.apache.org/jira/browse/QPID-1131
> Project: Qpid
> Issue Type: Improvement
> Components: Qpid Examples
> Affects Versions: M3
> Environment: Any
> Reporter: Manuel Teira
> Priority: Minor
> Fix For: M3
>
> Attachments: examples.patch
>
>
> Using ad-hoc makefiles for example generation and doesn't seem the best way to go, since autotools machinery is avoided, and they don't generate in all circunstances.
> I've changed it to use autotools, and to generate a proper simple staging Makefile, as expected.
> Also included is the refactoring of the directory hierarchy, unfortunately I'm not able to generate a proper patch since directories were moved, so, I'm including the whole procedure:
> (Some of the svn ops need to be forced):
> cd cpp/examples
> # Remove the current Makefiles, as they will be generated using autotools
> svn remove examples/Makefile
> svn remove examples/direct/Makefile
> svn remove examples/fanout/Makefile
> svn remove examples/pub-sub/Makefile
> svn remove examples/request-response/Makefile
> svn remove examples/xml-exchange/Makefile
> # Bring the examples to the current directory
> svn move README README.verify
> svn move examples/README README
> svn move examples/direct .
> svn move examples/fanout .
> svn move examples/pub-sub .
> svn move examples/xml-exchange .
> #After applying the attached patch
> #Add autotools machinery
> svn add makedist.mk
> svn add examples/direct/Makefile.am
> svn add examples/fanout/Makefile.am
> svn add examples/pub-sub/Makefile.am
> svn add examples/request-response/Makefile.am
> svn add examples/xml-exchange/Makefile.am
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.