You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/08/08 07:31:19 UTC

[GitHub] [guacamole-client] h8h opened a new pull request #636: Set "autofocus" to input field

h8h opened a new pull request #636:
URL: https://github.com/apache/guacamole-client/pull/636


   In some cases I start typing the totp code and the input field doesn't have focus. 
   
   So forcing an autofocus is more user friendly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] h8h commented on pull request #636: Set "autofocus" to input field

Posted by GitBox <gi...@apache.org>.
h8h commented on pull request #636:
URL: https://github.com/apache/guacamole-client/pull/636#issuecomment-899016781


   Okay.
   
   See https://issues.apache.org/jira/browse/GUACAMOLE-1397


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] h8h commented on pull request #636: GUACAMOLE-1397: Set "autofocus" to input field

Posted by GitBox <gi...@apache.org>.
h8h commented on pull request #636:
URL: https://github.com/apache/guacamole-client/pull/636#issuecomment-901999311


   Thank you very much for explaining this to me.
   
   I have change the commits. I hope its ok now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] mike-jumper merged pull request #636: GUACAMOLE-1397: AUTH-TOTP set autofocus to input field

Posted by GitBox <gi...@apache.org>.
mike-jumper merged pull request #636:
URL: https://github.com/apache/guacamole-client/pull/636


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] mike-jumper commented on pull request #636: Set "autofocus" to input field

Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #636:
URL: https://github.com/apache/guacamole-client/pull/636#issuecomment-895114263


   @h8h - thanks for the contribution! Please first create a JIRA issue describing the nature of the change, and then tag that JIRA issue within your commit(s) and the pull request itself. See our contribution guidelines:
   
   https://github.com/apache/guacamole-client/blob/master/CONTRIBUTING
   
   For real-world examples of the above, see other pull requests and the git commit history of this repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] mike-jumper commented on pull request #636: Set "autofocus" to input field

Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #636:
URL: https://github.com/apache/guacamole-client/pull/636#issuecomment-899828189


   Thanks, @h8h. Can you update your commit to include the JIRA issue (see above guidelines)? The git history is a good example for how the messages need to be formatted:
   
   https://github.com/apache/guacamole-client/commits/master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org