You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Hiram Chirino (JIRA)" <ji...@apache.org> on 2010/08/26 00:15:20 UTC
[jira] Created: (KARAF-166) Allow subclasses of
org.apache.karaf.shell.console.Main to be used as sub shells
Allow subclasses of org.apache.karaf.shell.console.Main to be used as sub shells
--------------------------------------------------------------------------------
Key: KARAF-166
URL: https://issues.apache.org/jira/browse/KARAF-166
Project: Karaf
Issue Type: New Feature
Components: console
Reporter: Hiram Chirino
Main would need to provide a run method which plays nicely with an existing CommandSession.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-166) Allow subclasses of
org.apache.karaf.shell.console.Main to be used as sub shells
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated KARAF-166:
--------------------------------
Attachment: KARAF-166-2nd.patch
Updated patch to apply cleanly against recent trunk chnages.
> Allow subclasses of org.apache.karaf.shell.console.Main to be used as sub shells
> --------------------------------------------------------------------------------
>
> Key: KARAF-166
> URL: https://issues.apache.org/jira/browse/KARAF-166
> Project: Karaf
> Issue Type: New Feature
> Components: console
> Reporter: Hiram Chirino
> Attachments: KARAF-166-2nd.patch
>
>
> Main would need to provide a run method which plays nicely with an existing CommandSession.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-166) Allow subclasses of
org.apache.karaf.shell.console.Main to be used as sub shells
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated KARAF-166:
--------------------------------
Attachment: (was: KARAF-166-2nd.patch)
> Allow subclasses of org.apache.karaf.shell.console.Main to be used as sub shells
> --------------------------------------------------------------------------------
>
> Key: KARAF-166
> URL: https://issues.apache.org/jira/browse/KARAF-166
> Project: Karaf
> Issue Type: New Feature
> Components: console
> Reporter: Hiram Chirino
> Attachments: KARAF-166-3rd.patch
>
>
> Main would need to provide a run method which plays nicely with an existing CommandSession.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-166) Allow subclasses of
org.apache.karaf.shell.console.Main to be used as sub shells
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated KARAF-166:
--------------------------------
Attachment: KARAF-166.patch
attaching patch that implements the feature.
> Allow subclasses of org.apache.karaf.shell.console.Main to be used as sub shells
> --------------------------------------------------------------------------------
>
> Key: KARAF-166
> URL: https://issues.apache.org/jira/browse/KARAF-166
> Project: Karaf
> Issue Type: New Feature
> Components: console
> Reporter: Hiram Chirino
> Attachments: KARAF-166.patch
>
>
> Main would need to provide a run method which plays nicely with an existing CommandSession.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-166) Allow subclasses of
org.apache.karaf.shell.console.Main to be used as sub shells
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated KARAF-166:
--------------------------------
Attachment: KARAF-166-3rd.patch
ops missed the update to Console in that last patch. Re-updating.
> Allow subclasses of org.apache.karaf.shell.console.Main to be used as sub shells
> --------------------------------------------------------------------------------
>
> Key: KARAF-166
> URL: https://issues.apache.org/jira/browse/KARAF-166
> Project: Karaf
> Issue Type: New Feature
> Components: console
> Reporter: Hiram Chirino
> Attachments: KARAF-166-3rd.patch
>
>
> Main would need to provide a run method which plays nicely with an existing CommandSession.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-166) Allow subclasses of
org.apache.karaf.shell.console.Main to be used as sub shells
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated KARAF-166:
--------------------------------
Attachment: (was: KARAF-166.patch)
> Allow subclasses of org.apache.karaf.shell.console.Main to be used as sub shells
> --------------------------------------------------------------------------------
>
> Key: KARAF-166
> URL: https://issues.apache.org/jira/browse/KARAF-166
> Project: Karaf
> Issue Type: New Feature
> Components: console
> Reporter: Hiram Chirino
> Attachments: KARAF-166-2nd.patch
>
>
> Main would need to provide a run method which plays nicely with an existing CommandSession.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-166) Allow subclasses of
org.apache.karaf.shell.console.Main to be used as sub shells
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902841#action_12902841 ]
Hiram Chirino commented on KARAF-166:
-------------------------------------
I don't mind my patch being adjusted. Who ever applies it is free to change it as much as he wants.
> Allow subclasses of org.apache.karaf.shell.console.Main to be used as sub shells
> --------------------------------------------------------------------------------
>
> Key: KARAF-166
> URL: https://issues.apache.org/jira/browse/KARAF-166
> Project: Karaf
> Issue Type: New Feature
> Components: console
> Reporter: Hiram Chirino
> Attachments: KARAF-166.patch
>
>
> Main would need to provide a run method which plays nicely with an existing CommandSession.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (KARAF-166) Allow subclasses of
org.apache.karaf.shell.console.Main to be used as sub shells
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved KARAF-166.
-----------------------------------
Assignee: Guillaume Nodet
Fix Version/s: 2.2.0
Resolution: Fixed
Committing to https://svn.apache.org/repos/asf/karaf/trunk ...
M shell/console/src/main/java/org/apache/karaf/shell/console/Main.java
M shell/console/src/main/java/org/apache/karaf/shell/console/jline/Console.java
Committed r989693
> Allow subclasses of org.apache.karaf.shell.console.Main to be used as sub shells
> --------------------------------------------------------------------------------
>
> Key: KARAF-166
> URL: https://issues.apache.org/jira/browse/KARAF-166
> Project: Karaf
> Issue Type: New Feature
> Components: console
> Reporter: Hiram Chirino
> Assignee: Guillaume Nodet
> Fix For: 2.2.0
>
> Attachments: KARAF-166-3rd.patch
>
>
> Main would need to provide a run method which plays nicely with an existing CommandSession.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-166) Allow subclasses of
org.apache.karaf.shell.console.Main to be used as sub shells
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902711#action_12902711 ]
Jamie goodyear commented on KARAF-166:
--------------------------------------
This sounds pretty cool :)
Just browsing through the patch, could you replace the "import java.io.*;" with all the required imports? I know it's a minor point, I just like to keep Karaf mostly free from import alls ;)
> Allow subclasses of org.apache.karaf.shell.console.Main to be used as sub shells
> --------------------------------------------------------------------------------
>
> Key: KARAF-166
> URL: https://issues.apache.org/jira/browse/KARAF-166
> Project: Karaf
> Issue Type: New Feature
> Components: console
> Reporter: Hiram Chirino
> Attachments: KARAF-166.patch
>
>
> Main would need to provide a run method which plays nicely with an existing CommandSession.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.