[jira] [Commented] (MESOS-9807) Introduce a `struct Quota` wrapper.

["Meng Zhu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858216#comment-16858216 ] 

Meng Zhu commented on MESOS-9807:
---------------------------------

{noformat}
commit 8fd52f1ad41c7aa131ceaac1b83a5bd1d06eca21
Author: Meng Zhu mzhu@mesosphere.io
Date:   Tue Jun 4 09:51:00 2019 -0700


Moved `class ResourceQuantities` to public header.

Some public facing classes such as `Resources` already depends
on `ResourceQuantities` and more are coming.

Review: https://reviews.apache.org/r/70786
{noformat}


> Introduce a `struct Quota` wrapper.
> -----------------------------------
>
>                 Key: MESOS-9807
>                 URL: https://issues.apache.org/jira/browse/MESOS-9807
>             Project: Mesos
>          Issue Type: Improvement
>          Components: allocation
>            Reporter: Meng Zhu
>            Priority: Major
>              Labels: resource-management
>
> We should introduce:
> struct Qutota {
>   ResourceQuantities guarantees;
>   ResourceLimits limits;
> }
> There are a couple of small hurdles. First, there is already a struct Quota wrapper in "include/mesos/quota/quota.hpp", we need to deprecate that first. Second, `ResourceQuantities` and `ResourceLimits` are right now only used in internal headers. We probably want to move them into public header, since this struct will also be used in allocator interface which is also in the public header. (Looking at this line, the boundary is alreayd breached: https://github.com/apache/mesos/blob/master/include/mesos/allocator/allocator.hpp#L41)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)