You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/17 19:27:29 UTC

[GitHub] [airflow] pgagnon commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook

pgagnon commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook
URL: https://github.com/apache/airflow/pull/6104#issuecomment-532366320
 
 
   I see this has just been merged, but nevertheless... I can see why this feature could be useful, but I am concerned that it might encourage users to paste key material in their code and subsequently publish it on their VCS. To put it mildly this is an inadvisable practice.
   
   @dstandish @mik-laj @kaxil WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services