[GitHub] zeppelin pull request #1888: [ZEPPELIN-1941] Fix deadlock in cron job

[OopsOutOfMemory <gi...@git.apache.org>]

GitHub user OopsOutOfMemory opened a pull request:

    https://github.com/apache/zeppelin/pull/1888

    [ZEPPELIN-1941] Fix deadlock in cron job

    ### What is this PR for?
    There is a deadlock in concurrent cron job execution with release resource option.
    Scenario:
    Two notebook run with cron job that release resource after job finished.
    In Notebook.CronJob.execute() method:
    T1. note.runAll(); // locked paragraphs(lock) and wait to interpreterSettings(lock)
    T2. notebook.getInterpreterFactory().restart() //locked(interpreterSettings) and wait for paragraphs(lock) during jobAbort.
    This will trigger a deadlock that cause zeppelin hang.
    
    ### What type of PR is it?
    [Bug Fix ]
    
    ### Todos
    * [ ] - Fix this by remove locking interpreterSettings in restart method
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
    
    ### How should this be tested?
    Outline the steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/OopsOutOfMemory/zeppelin cronjob_dl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1888
    
----
commit 81de4055498bce9da44e381930a917c5f2565123
Author: victor.sheng <vi...@qiniu.com>
Date:   2017-01-12T00:15:25Z

    fix deadlock in cron job

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---