You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by John Kordich via Review Board <no...@reviews.apache.org> on 2017/05/17 21:35:32 UTC
Review Request 59353: Enabled DOCKER and ROOT filter flags on Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59353/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Joseph Wu, and Li Li.
Repository: mesos
Description
-------
Enabled DOCKER and ROOT filter flags on Windows.
Diffs
-----
src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328
src/tests/containerizer/docker_tests.cpp 3d3c9afbe81ebdcdf7c5542c56f9ca0e17e2484d
src/tests/default_executor_tests.cpp 22af7e973f8e6ca583c3126a80bc092bf88fea33
src/tests/environment.cpp 047798c781707c42641baa9473177ae25a451989
src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5
Diff: https://reviews.apache.org/r/59353/diff/1/
Testing
-------
Tested on both Windows and Linux. Everything passes on Linux, but there are a number of tests that are failing on Windows. The tests that are failing on Windows are related to the tests that are currently failing on master on Windows. These tests are failing due to some long path changes in the Windows creators update, and I believe Andy is working on fixes to them.
Thanks,
John Kordich
Re: Review Request 59353: Enabled DOCKER and ROOT filter flags on
Windows.
Posted by Li Li <li...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59353/#review176125
-----------------------------------------------------------
Ship it!
Ship It!
- Li Li
On May 17, 2017, 9:35 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59353/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 9:35 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Joseph Wu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled DOCKER and ROOT filter flags on Windows.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328
> src/tests/containerizer/docker_tests.cpp 3d3c9afbe81ebdcdf7c5542c56f9ca0e17e2484d
> src/tests/default_executor_tests.cpp 22af7e973f8e6ca583c3126a80bc092bf88fea33
> src/tests/environment.cpp 047798c781707c42641baa9473177ae25a451989
> src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
> src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
> src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5
>
>
> Diff: https://reviews.apache.org/r/59353/diff/1/
>
>
> Testing
> -------
>
> Tested on both Windows and Linux. Everything passes on Linux, but there are a number of tests that are failing on Windows. The tests that are failing on Windows are related to the tests that are currently failing on master on Windows. These tests are failing due to some long path changes in the Windows creators update, and I believe Andy is working on fixes to them.
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 59353: Enabled DOCKER and ROOT filter flags on
Windows.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59353/#review176136
-----------------------------------------------------------
Fix it, then Ship it!
Mostly just white-space issues, so I'll fix those up before committing.
src/tests/default_executor_tests.cpp
Line 1430 (original), 1430-1431 (patched)
<https://reviews.apache.org/r/59353/#comment249471>
Whitespace:
```
TEST_P_TEMP_DISABLED_ON_WINDOWS(
PersistentVolumeDefaultExecutor, ROOT_PersistentResources)
```
src/tests/default_executor_tests.cpp
Line 1572 (original), 1573-1574 (patched)
<https://reviews.apache.org/r/59353/#comment249472>
Ditto about whitespace... and throughout this patch.
src/tests/environment.cpp
Line 268 (original)
<https://reviews.apache.org/r/59353/#comment249470>
```
#if defined(__linux__) || defined(__WINDOWS__)
```
We still don't support Docker tests on Posix, so this check should be modified rather than removed.
- Joseph Wu
On May 17, 2017, 2:35 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59353/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 2:35 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Joseph Wu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled DOCKER and ROOT filter flags on Windows.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328
> src/tests/containerizer/docker_tests.cpp 3d3c9afbe81ebdcdf7c5542c56f9ca0e17e2484d
> src/tests/default_executor_tests.cpp 22af7e973f8e6ca583c3126a80bc092bf88fea33
> src/tests/environment.cpp 047798c781707c42641baa9473177ae25a451989
> src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
> src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
> src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5
>
>
> Diff: https://reviews.apache.org/r/59353/diff/1/
>
>
> Testing
> -------
>
> Tested on both Windows and Linux. Everything passes on Linux, but there are a number of tests that are failing on Windows. The tests that are failing on Windows are related to the tests that are currently failing on master on Windows. These tests are failing due to some long path changes in the Windows creators update, and I believe Andy is working on fixes to them.
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 59353: Enabled DOCKER and ROOT filter flags on
Windows.
Posted by Li Li <li...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59353/#review176126
-----------------------------------------------------------
Ship it!
Ship It!
- Li Li
On May 17, 2017, 9:35 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59353/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 9:35 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Joseph Wu, and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled DOCKER and ROOT filter flags on Windows.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328
> src/tests/containerizer/docker_tests.cpp 3d3c9afbe81ebdcdf7c5542c56f9ca0e17e2484d
> src/tests/default_executor_tests.cpp 22af7e973f8e6ca583c3126a80bc092bf88fea33
> src/tests/environment.cpp 047798c781707c42641baa9473177ae25a451989
> src/tests/health_check_tests.cpp 6c1b9a0ead6edb34c20cf4973fffcff913c5d7ad
> src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
> src/tests/slave_tests.cpp 8f81f77aa29d16616d5a38197729baab0fb0cab5
>
>
> Diff: https://reviews.apache.org/r/59353/diff/1/
>
>
> Testing
> -------
>
> Tested on both Windows and Linux. Everything passes on Linux, but there are a number of tests that are failing on Windows. The tests that are failing on Windows are related to the tests that are currently failing on master on Windows. These tests are failing due to some long path changes in the Windows creators update, and I believe Andy is working on fixes to them.
>
>
> Thanks,
>
> John Kordich
>
>