You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "shuolinl (via GitHub)" <gi...@apache.org> on 2023/09/11 10:06:43 UTC
[GitHub] [iotdb] shuolinl opened a new pull request, #11118: Sl fix online upgrade
shuolinl opened a new pull request, #11118:
URL: https://github.com/apache/iotdb/pull/11118
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #11118: Sl fix online upgrade
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #11118:
URL: https://github.com/apache/iotdb/pull/11118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] shuolinl commented on pull request #11118: Sl fix online upgrade
Posted by "shuolinl (via GitHub)" <gi...@apache.org>.
shuolinl commented on PR #11118:
URL: https://github.com/apache/iotdb/pull/11118#issuecomment-1714844414
刚刚 force push 丢了一个 commit， 在另一台机器上，一会把他 cherry-pick 过来
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] shuolinl commented on a diff in pull request #11118: Sl fix online upgrade
Posted by "shuolinl (via GitHub)" <gi...@apache.org>.
shuolinl commented on code in PR #11118:
URL: https://github.com/apache/iotdb/pull/11118#discussion_r1321315969
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/executor/ConfigPlanExecutor.java:
##########
@@ -362,6 +362,17 @@ public TSStatus executeNonQueryPlan(ConfigPhysicalPlan physicalPlan)
case RevokeRole:
case RevokeRoleFromUser:
case UpdateUser:
+ case CreateUserDep:
+ case CreateRoleDep:
+ case DropUserDep:
+ case DropRoleDep:
+ case GrantRoleDep:
+ case GrantUserDep:
+ case GrantRoleToUserDep:
+ case RevokeUserDep:
+ case RevokeRoleDep:
+ case RevokeRoleFromUserDep:
+ case UpdateUserDep:
Review Comment:
这里需要再补全一下。
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/executor/ConfigPlanExecutor.java:
##########
@@ -362,6 +362,17 @@ public TSStatus executeNonQueryPlan(ConfigPhysicalPlan physicalPlan)
case RevokeRole:
case RevokeRoleFromUser:
case UpdateUser:
+ case CreateUserDep:
+ case CreateRoleDep:
+ case DropUserDep:
+ case DropRoleDep:
+ case GrantRoleDep:
+ case GrantUserDep:
+ case GrantRoleToUserDep:
+ case RevokeUserDep:
+ case RevokeRoleDep:
+ case RevokeRoleFromUserDep:
+ case UpdateUserDep:
Review Comment:
这里需要再补全一下。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #11118: Sl fix online upgrade
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 commented on code in PR #11118:
URL: https://github.com/apache/iotdb/pull/11118#discussion_r1322248531
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/IOUtils.java:
##########
@@ -117,6 +118,31 @@ public static String readString(
return null;
}
+ public static Pair<String, Boolean> readAuthString(
Review Comment:
add java doc for this method, at least that like: for IOTDB 1.2, the username's length will be stored as a negative number.
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/AuthorInfo.java:
##########
@@ -183,7 +183,21 @@ public TSStatus authorNonQuery(AuthorPlan authorPlan) {
List<PartialPath> nodeNameList = authorPlan.getNodeNameList();
try {
switch (authorType) {
+ case CreateUserDep:
+ case CreateRoleDep:
+ case DropUserDep:
+ case DropRoleDep:
+ case GrantUserDep:
+ case GrantRoleDep:
+ case GrantRoleToUserDep:
+ case RevokeUserDep:
+ case RevokeRoleDep:
+ case RevokeRoleFromUserDep:
+ throw new AuthException(
+ TSStatusCode.UNSUPPORTED_OPERATION,
+ "unsupport operation: " + authorPlan.getAuthorType());
Review Comment:
```suggestion
// TODO will deal with these authority upgrade soon in the future.
throw new AuthException(
TSStatusCode.UNSUPPORTED_OPERATION,
"unsupport operation: " + authorPlan.getAuthorType());
```
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/executor/ConfigPlanExecutor.java:
##########
@@ -362,6 +362,17 @@ public TSStatus executeNonQueryPlan(ConfigPhysicalPlan physicalPlan)
case RevokeRole:
case RevokeRoleFromUser:
case UpdateUser:
+ case CreateUserDep:
Review Comment:
```suggestion
// Dep for Deprecated
case CreateUserDep:
```
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/IOUtils.java:
##########
@@ -128,13 +154,26 @@ public static String readString(
* @throws IOException when an exception raised during operating the stream.
*/
public static PathPrivilege readPathPrivilege(
- DataInputStream inputStream, String encoding, ThreadLocal<byte[]> strBufferLocal)
+ DataInputStream inputStream,
+ String encoding,
+ ThreadLocal<byte[]> strBufferLocal,
+ boolean compatible)
Review Comment:
add java doc for this parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org