You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Artem Aliev (JIRA)" <ji...@apache.org> on 2006/12/04 12:27:22 UTC
[jira] Created: (HARMONY-2402)
java.io.ObjectInputStream.registerValidation throws InvalidObjectException
while RI throws NotActiveException
java.io.ObjectInputStream.registerValidation throws InvalidObjectException while RI throws NotActiveException
-------------------------------------------------------------------------------------------------------------
Key: HARMONY-2402
URL: http://issues.apache.org/jira/browse/HARMONY-2402
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Artem Aliev
Priority: Minor
java.io.ObjectInputStream.registerValidation throws InvalidObjectException
while RI throws NotActiveException.
Harmony checks first parameter and if ObjectInputValidation obj == null -
throws InvalidObjectException.
RI throws java.io.NotActiveException: stream inactive.
Looks like a bug in RI because according to the specification
method must throw InvalidObjectException if the validation object is null.
Test for reproducing:
import junit.framework.TestCase;
import java.io.*;
public class test extends TestCase {
public void test1 () {
ObjectInputStream obj=null;
try {
ByteArrayOutputStream byteArrayOutputStream = new
ByteArrayOutputStream();
new ObjectOutputStream(byteArrayOutputStream);
obj = new ObjectInputStream(new
ByteArrayInputStream(byteArrayOutputStream.toByteArray()));
} catch (IOException e) {
fail("unexpected IOException");
}
try {
obj.registerValidation(null,256);
fail("NotActiveException should be thrown");
} catch (NotActiveException e) {
//expected
} catch (InvalidObjectException e) {
fail("NotActiveException should be thrown");
}
}
}
Output on Sun 1.5:
==================
.F
Time: 0
There was 1 failure:
1) test1(test)junit.framework.AssertionFailedError: InvalidObjectException
should be thrown
at test.test1(test.java:20)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
sorImpl.java:25)
FAILURES!!!
Tests run: 1, Failures: 1, Errors: 0
Output on Harmony:
==================
.
Time: 0.079
OK (1 test)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2402) [classlib][luni]
java.io.ObjectInputStream.registerValidation throws InvalidObjectException
while RI throws NotActiveException
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2402?page=all ]
Alexei Zakharov updated HARMONY-2402:
-------------------------------------
Summary: [classlib][luni] java.io.ObjectInputStream.registerValidation throws InvalidObjectException while RI throws NotActiveException (was: java.io.ObjectInputStream.registerValidation throws InvalidObjectException while RI throws NotActiveException)
> [classlib][luni] java.io.ObjectInputStream.registerValidation throws InvalidObjectException while RI throws NotActiveException
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2402
> URL: http://issues.apache.org/jira/browse/HARMONY-2402
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Artem Aliev
> Priority: Minor
>
> java.io.ObjectInputStream.registerValidation throws InvalidObjectException
> while RI throws NotActiveException.
> Harmony checks first parameter and if ObjectInputValidation obj == null -
> throws InvalidObjectException.
> RI throws java.io.NotActiveException: stream inactive.
> Looks like a bug in RI because according to the specification
> method must throw InvalidObjectException if the validation object is null.
> Test for reproducing:
> import junit.framework.TestCase;
> import java.io.*;
> public class test extends TestCase {
> public void test1 () {
> ObjectInputStream obj=null;
> try {
> ByteArrayOutputStream byteArrayOutputStream = new
> ByteArrayOutputStream();
> new ObjectOutputStream(byteArrayOutputStream);
> obj = new ObjectInputStream(new
> ByteArrayInputStream(byteArrayOutputStream.toByteArray()));
> } catch (IOException e) {
> fail("unexpected IOException");
> }
> try {
> obj.registerValidation(null,256);
> fail("NotActiveException should be thrown");
> } catch (NotActiveException e) {
> //expected
> } catch (InvalidObjectException e) {
> fail("NotActiveException should be thrown");
> }
> }
> }
> Output on Sun 1.5:
> ==================
> .F
> Time: 0
> There was 1 failure:
> 1) test1(test)junit.framework.AssertionFailedError: InvalidObjectException
> should be thrown
> at test.test1(test.java:20)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
> sorImpl.java:25)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
> Output on Harmony:
> ==================
> .
> Time: 0.079
> OK (1 test)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-2402) [classlib][luni]
java.io.ObjectInputStream.registerValidation throws InvalidObjectException
while RI throws NotActiveException
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2402?page=all ]
Tim Ellison reassigned HARMONY-2402:
------------------------------------
Assignee: Tim Ellison
> [classlib][luni] java.io.ObjectInputStream.registerValidation throws InvalidObjectException while RI throws NotActiveException
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2402
> URL: http://issues.apache.org/jira/browse/HARMONY-2402
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Artem Aliev
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: H-2402.patch
>
>
> java.io.ObjectInputStream.registerValidation throws InvalidObjectException
> while RI throws NotActiveException.
> Harmony checks first parameter and if ObjectInputValidation obj == null -
> throws InvalidObjectException.
> RI throws java.io.NotActiveException: stream inactive.
> Looks like a bug in RI because according to the specification
> method must throw InvalidObjectException if the validation object is null.
> Test for reproducing:
> import junit.framework.TestCase;
> import java.io.*;
> public class test extends TestCase {
> public void test1 () {
> ObjectInputStream obj=null;
> try {
> ByteArrayOutputStream byteArrayOutputStream = new
> ByteArrayOutputStream();
> new ObjectOutputStream(byteArrayOutputStream);
> obj = new ObjectInputStream(new
> ByteArrayInputStream(byteArrayOutputStream.toByteArray()));
> } catch (IOException e) {
> fail("unexpected IOException");
> }
> try {
> obj.registerValidation(null,256);
> fail("NotActiveException should be thrown");
> } catch (NotActiveException e) {
> //expected
> } catch (InvalidObjectException e) {
> fail("NotActiveException should be thrown");
> }
> }
> }
> Output on Sun 1.5:
> ==================
> .F
> Time: 0
> There was 1 failure:
> 1) test1(test)junit.framework.AssertionFailedError: InvalidObjectException
> should be thrown
> at test.test1(test.java:20)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
> sorImpl.java:25)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
> Output on Harmony:
> ==================
> .
> Time: 0.079
> OK (1 test)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2402) [classlib][luni]
java.io.ObjectInputStream.registerValidation throws InvalidObjectException
while RI throws NotActiveException
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison closed HARMONY-2402.
--------------------------------
Verified by Mikhail.
> [classlib][luni] java.io.ObjectInputStream.registerValidation throws InvalidObjectException while RI throws NotActiveException
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2402
> URL: https://issues.apache.org/jira/browse/HARMONY-2402
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Artem Aliev
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: H-2402.patch
>
>
> java.io.ObjectInputStream.registerValidation throws InvalidObjectException
> while RI throws NotActiveException.
> Harmony checks first parameter and if ObjectInputValidation obj == null -
> throws InvalidObjectException.
> RI throws java.io.NotActiveException: stream inactive.
> Looks like a bug in RI because according to the specification
> method must throw InvalidObjectException if the validation object is null.
> Test for reproducing:
> import junit.framework.TestCase;
> import java.io.*;
> public class test extends TestCase {
> public void test1 () {
> ObjectInputStream obj=null;
> try {
> ByteArrayOutputStream byteArrayOutputStream = new
> ByteArrayOutputStream();
> new ObjectOutputStream(byteArrayOutputStream);
> obj = new ObjectInputStream(new
> ByteArrayInputStream(byteArrayOutputStream.toByteArray()));
> } catch (IOException e) {
> fail("unexpected IOException");
> }
> try {
> obj.registerValidation(null,256);
> fail("NotActiveException should be thrown");
> } catch (NotActiveException e) {
> //expected
> } catch (InvalidObjectException e) {
> fail("NotActiveException should be thrown");
> }
> }
> }
> Output on Sun 1.5:
> ==================
> .F
> Time: 0
> There was 1 failure:
> 1) test1(test)junit.framework.AssertionFailedError: InvalidObjectException
> should be thrown
> at test.test1(test.java:20)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
> sorImpl.java:25)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
> Output on Harmony:
> ==================
> .
> Time: 0.079
> OK (1 test)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2402) [classlib][luni]
java.io.ObjectInputStream.registerValidation throws InvalidObjectException
while RI throws NotActiveException
Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2402?page=comments#action_12460459 ]
Tony Wu commented on HARMONY-2402:
----------------------------------
+1 to non-bug difference
> [classlib][luni] java.io.ObjectInputStream.registerValidation throws InvalidObjectException while RI throws NotActiveException
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2402
> URL: http://issues.apache.org/jira/browse/HARMONY-2402
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Artem Aliev
> Priority: Minor
>
> java.io.ObjectInputStream.registerValidation throws InvalidObjectException
> while RI throws NotActiveException.
> Harmony checks first parameter and if ObjectInputValidation obj == null -
> throws InvalidObjectException.
> RI throws java.io.NotActiveException: stream inactive.
> Looks like a bug in RI because according to the specification
> method must throw InvalidObjectException if the validation object is null.
> Test for reproducing:
> import junit.framework.TestCase;
> import java.io.*;
> public class test extends TestCase {
> public void test1 () {
> ObjectInputStream obj=null;
> try {
> ByteArrayOutputStream byteArrayOutputStream = new
> ByteArrayOutputStream();
> new ObjectOutputStream(byteArrayOutputStream);
> obj = new ObjectInputStream(new
> ByteArrayInputStream(byteArrayOutputStream.toByteArray()));
> } catch (IOException e) {
> fail("unexpected IOException");
> }
> try {
> obj.registerValidation(null,256);
> fail("NotActiveException should be thrown");
> } catch (NotActiveException e) {
> //expected
> } catch (InvalidObjectException e) {
> fail("NotActiveException should be thrown");
> }
> }
> }
> Output on Sun 1.5:
> ==================
> .F
> Time: 0
> There was 1 failure:
> 1) test1(test)junit.framework.AssertionFailedError: InvalidObjectException
> should be thrown
> at test.test1(test.java:20)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
> sorImpl.java:25)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
> Output on Harmony:
> ==================
> .
> Time: 0.079
> OK (1 test)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2402) [classlib][luni]
java.io.ObjectInputStream.registerValidation throws InvalidObjectException
while RI throws NotActiveException
Posted by "Mikhail Markov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2402?page=all ]
Mikhail Markov updated HARMONY-2402:
------------------------------------
Attachment: H-2402.patch
I'm not fully agree.
According to API spec registerValidation() method could throw both exceptions:
1) NotActiveException if the stream is not currently reading objects (i.e. inactive)
2) InvalidObjectException if the validation object is null.
So, both RI & Harmony follow the spec. Unfortunately API sped does not describe the sequence of parameter's checks.
I thinks it would be easier to follow RI, morover, the swapping of these 2 checks will not decrease performance at all.
Just in case i've provided the patch which just swapping these 2 checks (+ patch for unit test).
> [classlib][luni] java.io.ObjectInputStream.registerValidation throws InvalidObjectException while RI throws NotActiveException
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2402
> URL: http://issues.apache.org/jira/browse/HARMONY-2402
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Artem Aliev
> Priority: Minor
> Attachments: H-2402.patch
>
>
> java.io.ObjectInputStream.registerValidation throws InvalidObjectException
> while RI throws NotActiveException.
> Harmony checks first parameter and if ObjectInputValidation obj == null -
> throws InvalidObjectException.
> RI throws java.io.NotActiveException: stream inactive.
> Looks like a bug in RI because according to the specification
> method must throw InvalidObjectException if the validation object is null.
> Test for reproducing:
> import junit.framework.TestCase;
> import java.io.*;
> public class test extends TestCase {
> public void test1 () {
> ObjectInputStream obj=null;
> try {
> ByteArrayOutputStream byteArrayOutputStream = new
> ByteArrayOutputStream();
> new ObjectOutputStream(byteArrayOutputStream);
> obj = new ObjectInputStream(new
> ByteArrayInputStream(byteArrayOutputStream.toByteArray()));
> } catch (IOException e) {
> fail("unexpected IOException");
> }
> try {
> obj.registerValidation(null,256);
> fail("NotActiveException should be thrown");
> } catch (NotActiveException e) {
> //expected
> } catch (InvalidObjectException e) {
> fail("NotActiveException should be thrown");
> }
> }
> }
> Output on Sun 1.5:
> ==================
> .F
> Time: 0
> There was 1 failure:
> 1) test1(test)junit.framework.AssertionFailedError: InvalidObjectException
> should be thrown
> at test.test1(test.java:20)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
> sorImpl.java:25)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
> Output on Harmony:
> ==================
> .
> Time: 0.079
> OK (1 test)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2402) [classlib][luni]
java.io.ObjectInputStream.registerValidation throws InvalidObjectException
while RI throws NotActiveException
Posted by "Mikhail Markov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463271 ]
Mikhail Markov commented on HARMONY-2402:
-----------------------------------------
Yes, Tim - sure your modification is much more readable. Thanks for doing this!
Now test works as expected.
> [classlib][luni] java.io.ObjectInputStream.registerValidation throws InvalidObjectException while RI throws NotActiveException
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2402
> URL: https://issues.apache.org/jira/browse/HARMONY-2402
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Artem Aliev
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: H-2402.patch
>
>
> java.io.ObjectInputStream.registerValidation throws InvalidObjectException
> while RI throws NotActiveException.
> Harmony checks first parameter and if ObjectInputValidation obj == null -
> throws InvalidObjectException.
> RI throws java.io.NotActiveException: stream inactive.
> Looks like a bug in RI because according to the specification
> method must throw InvalidObjectException if the validation object is null.
> Test for reproducing:
> import junit.framework.TestCase;
> import java.io.*;
> public class test extends TestCase {
> public void test1 () {
> ObjectInputStream obj=null;
> try {
> ByteArrayOutputStream byteArrayOutputStream = new
> ByteArrayOutputStream();
> new ObjectOutputStream(byteArrayOutputStream);
> obj = new ObjectInputStream(new
> ByteArrayInputStream(byteArrayOutputStream.toByteArray()));
> } catch (IOException e) {
> fail("unexpected IOException");
> }
> try {
> obj.registerValidation(null,256);
> fail("NotActiveException should be thrown");
> } catch (NotActiveException e) {
> //expected
> } catch (InvalidObjectException e) {
> fail("NotActiveException should be thrown");
> }
> }
> }
> Output on Sun 1.5:
> ==================
> .F
> Time: 0
> There was 1 failure:
> 1) test1(test)junit.framework.AssertionFailedError: InvalidObjectException
> should be thrown
> at test.test1(test.java:20)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
> sorImpl.java:25)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
> Output on Harmony:
> ==================
> .
> Time: 0.079
> OK (1 test)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-2402) [classlib][luni]
java.io.ObjectInputStream.registerValidation throws InvalidObjectException
while RI throws NotActiveException
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2402?page=all ]
Tim Ellison resolved HARMONY-2402.
----------------------------------
Resolution: Fixed
I agree with Mikhail, that we should follow exception throwing order. I've applied Mikhail's patch, and couldn't help myself slightly reordering the code to make it more readable.
Code fixed in LUNI module at repo revision r491091.
Artem, please check that this fully resolves the problem.
> [classlib][luni] java.io.ObjectInputStream.registerValidation throws InvalidObjectException while RI throws NotActiveException
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2402
> URL: http://issues.apache.org/jira/browse/HARMONY-2402
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Artem Aliev
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: H-2402.patch
>
>
> java.io.ObjectInputStream.registerValidation throws InvalidObjectException
> while RI throws NotActiveException.
> Harmony checks first parameter and if ObjectInputValidation obj == null -
> throws InvalidObjectException.
> RI throws java.io.NotActiveException: stream inactive.
> Looks like a bug in RI because according to the specification
> method must throw InvalidObjectException if the validation object is null.
> Test for reproducing:
> import junit.framework.TestCase;
> import java.io.*;
> public class test extends TestCase {
> public void test1 () {
> ObjectInputStream obj=null;
> try {
> ByteArrayOutputStream byteArrayOutputStream = new
> ByteArrayOutputStream();
> new ObjectOutputStream(byteArrayOutputStream);
> obj = new ObjectInputStream(new
> ByteArrayInputStream(byteArrayOutputStream.toByteArray()));
> } catch (IOException e) {
> fail("unexpected IOException");
> }
> try {
> obj.registerValidation(null,256);
> fail("NotActiveException should be thrown");
> } catch (NotActiveException e) {
> //expected
> } catch (InvalidObjectException e) {
> fail("NotActiveException should be thrown");
> }
> }
> }
> Output on Sun 1.5:
> ==================
> .F
> Time: 0
> There was 1 failure:
> 1) test1(test)junit.framework.AssertionFailedError: InvalidObjectException
> should be thrown
> at test.test1(test.java:20)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
> sorImpl.java:25)
> FAILURES!!!
> Tests run: 1, Failures: 1, Errors: 0
> Output on Harmony:
> ==================
> .
> Time: 0.079
> OK (1 test)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira