You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/07/17 09:47:21 UTC
Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23605/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-7074 and CLOUDSTACK-7107
https://issues.apache.org/jira/browse/CLOUDSTACK-7074
https://issues.apache.org/jira/browse/CLOUDSTACK-7107
Repository: cloudstack-git
Description
-------
Disabling failed test cases on master.
Diffs
-----
test/integration/smoke/test_primary_storage.py 66aec59
test/integration/smoke/test_vm_life_cycle.py 240ab68
Diff: https://reviews.apache.org/r/23605/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23605/#review47990
-----------------------------------------------------------
Commit 186606a0bf82402e7755cd7998f133023cc96c6c in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=186606a ]
CLOUDSTACK-7107: Disabling failed test case
- ASF Subversion and Git Services
On July 17, 2014, 7:47 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23605/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 7:47 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7074 and CLOUDSTACK-7107
> https://issues.apache.org/jira/browse/CLOUDSTACK-7074
> https://issues.apache.org/jira/browse/CLOUDSTACK-7107
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Disabling failed test cases on master.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_primary_storage.py 66aec59
> test/integration/smoke/test_vm_life_cycle.py 240ab68
>
> Diff: https://reviews.apache.org/r/23605/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23605/#review48203
-----------------------------------------------------------
Commit 43dffaad5fd197c87a8dab087066f677a095dee7 in cloudstack's branch refs/heads/master from Koushik Das
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=43dffaa ]
Revert "CLOUDSTACK-7107: Disabling failed test case"
This reverts commit 186606a0bf82402e7755cd7998f133023cc96c6c.
- ASF Subversion and Git Services
On July 17, 2014, 7:47 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23605/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 7:47 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7074 and CLOUDSTACK-7107
> https://issues.apache.org/jira/browse/CLOUDSTACK-7074
> https://issues.apache.org/jira/browse/CLOUDSTACK-7107
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Disabling failed test cases on master.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_primary_storage.py 66aec59
> test/integration/smoke/test_vm_life_cycle.py 240ab68
>
> Diff: https://reviews.apache.org/r/23605/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases
Posted by Hugo Trippaers <hu...@trippaers.nl>.
Hey Gaurav,
That doesn’t make a lot of sense to me. If the test sequence fails because of a bug it should keep failing until the bug is resolved, otherwise the tests will report that the situation is OK while in all reality it is not. These test should be in indication that Apache CloudStack is ready to release and if we hide tests that are failing we will never know the real status of the tests and give false information to people depending on the tests.
Cheers,
Hugo
On 21 jul. 2014, at 10:58, Gaurav Aradhye <ga...@clogeny.com> wrote:
>
>
>> On July 21, 2014, 1:03 p.m., Hugo Trippaers wrote:
>>> Why would we want to disable test cases that fail? Doesn't this mean we need to fix something else so they don't fail anymore?
>
> Hi Hugo,
>
> Whenever we found a test case failing, we create bug for that, may it be a test script issue or product bug, so that the test case gets associated with a particular bug and it's easy to track in future why it is failing.
>
> Addition of this decorator BugId to test case skips the test in the run.
>
> Whenever the bug gets fixed, then the person who has fixed the bug removes the BugId decorator from test case so that the test case gets picked up in the next run.
>
>
> - Gaurav
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23605/#review48204
> -----------------------------------------------------------
>
>
> On July 17, 2014, 1:17 p.m., Gaurav Aradhye wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/23605/
>> -----------------------------------------------------------
>>
>> (Updated July 17, 2014, 1:17 p.m.)
>>
>>
>> Review request for cloudstack and Girish Shilamkar.
>>
>>
>> Bugs: CLOUDSTACK-7074 and CLOUDSTACK-7107
>> https://issues.apache.org/jira/browse/CLOUDSTACK-7074
>> https://issues.apache.org/jira/browse/CLOUDSTACK-7107
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> Disabling failed test cases on master.
>>
>>
>> Diffs
>> -----
>>
>> test/integration/smoke/test_primary_storage.py 66aec59
>> test/integration/smoke/test_vm_life_cycle.py 240ab68
>>
>> Diff: https://reviews.apache.org/r/23605/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Gaurav Aradhye
>>
>>
>
Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On July 21, 2014, 1:03 p.m., Hugo Trippaers wrote:
> > Why would we want to disable test cases that fail? Doesn't this mean we need to fix something else so they don't fail anymore?
Hi Hugo,
Whenever we found a test case failing, we create bug for that, may it be a test script issue or product bug, so that the test case gets associated with a particular bug and it's easy to track in future why it is failing.
Addition of this decorator BugId to test case skips the test in the run.
Whenever the bug gets fixed, then the person who has fixed the bug removes the BugId decorator from test case so that the test case gets picked up in the next run.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23605/#review48204
-----------------------------------------------------------
On July 17, 2014, 1:17 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23605/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 1:17 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7074 and CLOUDSTACK-7107
> https://issues.apache.org/jira/browse/CLOUDSTACK-7074
> https://issues.apache.org/jira/browse/CLOUDSTACK-7107
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Disabling failed test cases on master.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_primary_storage.py 66aec59
> test/integration/smoke/test_vm_life_cycle.py 240ab68
>
> Diff: https://reviews.apache.org/r/23605/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23605/#review48204
-----------------------------------------------------------
Why would we want to disable test cases that fail? Doesn't this mean we need to fix something else so they don't fail anymore?
- Hugo Trippaers
On July 17, 2014, 7:47 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23605/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 7:47 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7074 and CLOUDSTACK-7107
> https://issues.apache.org/jira/browse/CLOUDSTACK-7074
> https://issues.apache.org/jira/browse/CLOUDSTACK-7107
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Disabling failed test cases on master.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_primary_storage.py 66aec59
> test/integration/smoke/test_vm_life_cycle.py 240ab68
>
> Diff: https://reviews.apache.org/r/23605/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>