You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/06/14 20:30:42 UTC

[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #876: IGNITE-17093 Map error codes for cli commands

Pochatkin commented on code in PR #876:
URL: https://github.com/apache/ignite-3/pull/876#discussion_r897276506


##########
modules/cli/src/main/java/org/apache/ignite/cli/Main.java:
##########
@@ -54,11 +54,12 @@ public class Main {
     public static void main(String[] args) {
         initJavaLoggerProps();
 
+        int exitCode = 0;

Review Comment:
   I think this can be a problem. I mean starting with exit code 0. Lets imagine that  AnsiConsole.systemInstall(); throw some exeption and in this case we will have failed to start CLI and will have 0(success) exit code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org