You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/13 09:43:32 UTC

[GitHub] [flink] tillrohrmann commented on a change in pull request #14593: [FLINK-20903] Remove unnecessary methods from SchedulerNG

tillrohrmann commented on a change in pull request #14593:
URL: https://github.com/apache/flink/pull/14593#discussion_r556387762



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/SchedulerTestingUtils.java
##########
@@ -103,12 +105,15 @@
 
     private SchedulerTestingUtils() {}
 
-    public static DefaultSchedulerBuilder newSchedulerBuilder(final JobGraph jobGraph) {
-        return new DefaultSchedulerBuilder(jobGraph);
+    public static DefaultSchedulerBuilder newSchedulerBuilder(

Review comment:
       This is true. At the moment I would like to make it explicit that the user has to choose a concrete `ComponentMainThreadExecutor` to run this component.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org