You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/08/24 07:17:30 UTC
Review Request 68486: Added `cli_new` to the excluded directories for
Python 2 mesos-style.py.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68486/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-9112
https://issues.apache.org/jira/browse/MESOS-9112
Repository: mesos
Description
-------
This way, pylint does not report outdated errors when the old mesos-style.py is run.
Diffs
-----
support/mesos-style.py a0ef221e7d884a73c551e657d538438ec98eed65
Diff: https://reviews.apache.org/r/68486/diff/1/
Testing
-------
Using mesos-style, before:
```
Checking 46 Python files
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
************* Module cli.plugins.base
E:119, 0: Bad option value 'R0204' (bad-option-value)
************* Module settings
E: 32, 4: No name 'VERSION' in module 'version' (no-name-in-module)
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
************* Module mesos.http
E: 25, 0: Unable to import 'urlparse' (import-error)
E: 87,30: Undefined variable 'xrange' (undefined-variable)
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
Total errors found: 4
```
After:
```
Checking 21 Python files
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
************* Module mesos.http
E: 25, 0: Unable to import 'urlparse' (import-error)
E: 87,30: Undefined variable 'xrange' (undefined-variable)
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
Total errors found: 2
```
Thanks,
Armand Grillet
Re: Review Request 68486: Added `cli_new` to the excluded directories
for Python 2 mesos-style.py.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68486/#review207861
-----------------------------------------------------------
PASS: Mesos patch 68486 was successfully built and tested.
Reviews applied: `['68485', '68486']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2230/mesos-review-68486
- Mesos Reviewbot Windows
On Aug. 24, 2018, 7:17 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68486/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 7:17 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9112
> https://issues.apache.org/jira/browse/MESOS-9112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This way, pylint does not report outdated errors when the old mesos-style.py is run.
>
>
> Diffs
> -----
>
> support/mesos-style.py a0ef221e7d884a73c551e657d538438ec98eed65
>
>
> Diff: https://reviews.apache.org/r/68486/diff/1/
>
>
> Testing
> -------
>
> Using mesos-style, before:
> ```
> Checking 46 Python files
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> ************* Module cli.plugins.base
> E:119, 0: Bad option value 'R0204' (bad-option-value)
> ************* Module settings
> E: 32, 4: No name 'VERSION' in module 'version' (no-name-in-module)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> ************* Module mesos.http
> E: 25, 0: Unable to import 'urlparse' (import-error)
> E: 87,30: Undefined variable 'xrange' (undefined-variable)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> Total errors found: 4
> ```
> After:
> ```
> Checking 21 Python files
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> ************* Module mesos.http
> E: 25, 0: Unable to import 'urlparse' (import-error)
> E: 87,30: Undefined variable 'xrange' (undefined-variable)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> Total errors found: 2
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68486: Added `cli_new` to the excluded directories
for Python 2 mesos-style.py.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68486/#review207870
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68485, 68486]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 24, 2018, 12:17 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68486/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 12:17 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9112
> https://issues.apache.org/jira/browse/MESOS-9112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This way, pylint does not report outdated errors when the old mesos-style.py is run.
>
>
> Diffs
> -----
>
> support/mesos-style.py a0ef221e7d884a73c551e657d538438ec98eed65
>
>
> Diff: https://reviews.apache.org/r/68486/diff/1/
>
>
> Testing
> -------
>
> Using mesos-style, before:
> ```
> Checking 46 Python files
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> ************* Module cli.plugins.base
> E:119, 0: Bad option value 'R0204' (bad-option-value)
> ************* Module settings
> E: 32, 4: No name 'VERSION' in module 'version' (no-name-in-module)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> ************* Module mesos.http
> E: 25, 0: Unable to import 'urlparse' (import-error)
> E: 87,30: Undefined variable 'xrange' (undefined-variable)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> Total errors found: 4
> ```
> After:
> ```
> Checking 21 Python files
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> ************* Module mesos.http
> E: 25, 0: Unable to import 'urlparse' (import-error)
> E: 87,30: Undefined variable 'xrange' (undefined-variable)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> Total errors found: 2
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68486: Added `cli_new` to the excluded directories
for Python 2 mesos-style.py.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68486/#review207949
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Aug. 24, 2018, 9:17 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68486/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 9:17 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9112
> https://issues.apache.org/jira/browse/MESOS-9112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This way, pylint does not report outdated errors when the old mesos-style.py is run.
>
>
> Diffs
> -----
>
> support/mesos-style.py a0ef221e7d884a73c551e657d538438ec98eed65
>
>
> Diff: https://reviews.apache.org/r/68486/diff/1/
>
>
> Testing
> -------
>
> Using mesos-style, before:
> ```
> Checking 46 Python files
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> ************* Module cli.plugins.base
> E:119, 0: Bad option value 'R0204' (bad-option-value)
> ************* Module settings
> E: 32, 4: No name 'VERSION' in module 'version' (no-name-in-module)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> ************* Module mesos.http
> E: 25, 0: Unable to import 'urlparse' (import-error)
> E: 87,30: Undefined variable 'xrange' (undefined-variable)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> Total errors found: 4
> ```
> After:
> ```
> Checking 21 Python files
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> ************* Module mesos.http
> E: 25, 0: Unable to import 'urlparse' (import-error)
> E: 87,30: Undefined variable 'xrange' (undefined-variable)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> Total errors found: 2
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>