You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Svet <no...@github.com> on 2017/07/06 07:55:04 UTC

[jclouds/jclouds-labs] Fix SGE.removeSecurityGroup for when the SG doesn't exist (#399)

@nacx reported the problem in the `Re: [DISCUSS] Release Apache jclouds 2.0.2 RC1` email thread. Failure:

```
testSecurityGroupCacheInvalidatedWhenDeletedExternally(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest)
Time elapsed: 2.928 sec  <<< FAILURE!
java.lang.NullPointerException: uri cannot be null
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:229)
at org.jclouds.azurecompute.arm.compute.config.AzureComputeServiceContextModule$ActionDonePredicate.apply(AzureComputeServiceContextModule.java:230)
at org.jclouds.azurecompute.arm.compute.config.AzureComputeServiceContextModule$ActionDonePredicate.apply(AzureComputeServiceContextModule.java:219)
at org.jclouds.util.Predicates2$RetryablePredicate.apply(Predicates2.java:117)
at org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtension.removeSecurityGroup(AzureComputeSecurityGroupExtension.java:193)
at org.jclouds.compute.extensions.internal.BaseSecurityGroupExtensionLiveTest.testSecurityGroupCacheInvalidatedWhenDeletedExternally(BaseSecurityGroupExtensionLiveTest.java:417)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:85)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:696)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:882)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1189)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:124)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
at org.testng.TestRunner.privateRun(TestRunner.java:767)
at org.testng.TestRunner.run(TestRunner.java:617)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
at org.testng.SuiteRunner.access$000(SuiteRunner.java:38)
at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:382)
at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
```
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/399

-- Commit Summary --

  * Fix SGE.removeSecurityGroup for when the SG doesn't exist

-- File Changes --

    M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/extensions/AzureComputeSecurityGroupExtension.java (10)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/399.patch
https://github.com/jclouds/jclouds-labs/pull/399.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/399

Re: [jclouds/jclouds-labs] Fix SGE.removeSecurityGroup for when the SG doesn't exist (#399)

Posted by Svet <no...@github.com>.
Closed #399.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/399#event-1154029335

Re: [jclouds/jclouds-labs] Fix SGE.removeSecurityGroup for when the SG doesn't exist (#399)

Posted by Svet <no...@github.com>.
Merged in [master](https://git1-us-west.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=1450892fd841b683fc5da5acb38a853b5e45605b) and [2.0.x](https://git1-us-west.apache.org/repos/asf?p=jclouds-labs.git;a=shortlog;h=refs/heads/2.0.x).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/399#issuecomment-313612033

Re: [jclouds/jclouds-labs] Fix SGE.removeSecurityGroup for when the SG doesn't exist (#399)

Posted by Ignasi Barrera <no...@github.com>.
nacx approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/399#pullrequestreview-48346148

Re: [jclouds/jclouds-labs] Fix SGE.removeSecurityGroup for when the SG doesn't exist (#399)

Posted by Svet <no...@github.com>.
Thanks @nacx, merging.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/399#issuecomment-313610076

Re: [jclouds/jclouds-labs] Fix SGE.removeSecurityGroup for when the SG doesn't exist (#399)

Posted by stevegomez17 <no...@github.com>.
stevegomez17 commented on this pull request.

stevegomez17



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/399#pullrequestreview-63501016