You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/02 11:13:59 UTC
[GitHub] [incubator-seatunnel] zhaomin1423 opened a new pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
zhaomin1423 opened a new pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
update httpclient version to 4.5.13 because of doris connection reset.
refer doc: https://doris.apache.org/zh-CN/administrator-guide/load-data/stream-load-manual.html#%E5%B8%B8%E8%A7%81%E9%97%AE%E9%A2%98
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818297615
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,7 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
(Apache License, Version 2.0) Apache HttpClient Mime (org.apache.httpcomponents:httpmime:4.5.2 - http://hc.apache.org/httpcomponents-client)
Review comment:
@CalvinKirs It is normal, we should be glad that the checker is working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818263130
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,7 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
(Apache License, Version 2.0) Apache HttpClient Mime (org.apache.httpcomponents:httpmime:4.5.2 - http://hc.apache.org/httpcomponents-client)
Review comment:
That's not your problem, hi, @asdf2014 can you take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhaomin1423 commented on pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#issuecomment-1057092506
> commons-codec-1.11.jar
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1372: [Improve][Connectors]update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818692923
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,8 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache Commons Codec (commons-codec:commons-codec:1.11 - https://commons.apache.org/proper/commons-codec)
Review comment:
It has been solved by https://github.com/apache/incubator-seatunnel/pull/1387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhaomin1423 commented on pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#issuecomment-1056935101
> hi,please refer this :https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md
>
> resolve license error.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhaomin1423 commented on pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#issuecomment-1057057165
> Some checks were not successful
> hi,please refer this :https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md
>
> resolve license error.
Hi, Some checks were not successful. what do I need to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#issuecomment-1056920880
hi,please refer this :https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md
resolve license error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#issuecomment-1057070693
> > Some checks were not successful
>
> > hi,please refer this :https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md
> > resolve license error.
>
> Hi, Some checks were not successful. what do I need to do?
and need add this : `commons-codec-1.11.jar`
```
+commons-codec-1.11.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r817892871
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,7 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
(Apache License, Version 2.0) Apache HttpClient Mime (org.apache.httpcomponents:httpmime:4.5.2 - http://hc.apache.org/httpcomponents-client)
Review comment:
you need to add `commons-codec` here,
I checked NOTICE and he didn't change, so just make the changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818301391
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,7 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
(Apache License, Version 2.0) Apache HttpClient Mime (org.apache.httpcomponents:httpmime:4.5.2 - http://hc.apache.org/httpcomponents-client)
Review comment:
Am I missing something? I saw that the license item has been done, and this error is very strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1372: [Improve][Connectors]update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhaomin1423 commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818263523
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,7 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
(Apache License, Version 2.0) Apache HttpClient Mime (org.apache.httpcomponents:httpmime:4.5.2 - http://hc.apache.org/httpcomponents-client)
Review comment:
> That's not your problem, hi, @asdf2014 can you take a look at this?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818303318
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,8 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache Commons Codec (commons-codec:commons-codec:1.11 - https://commons.apache.org/proper/commons-codec)
Review comment:
@zhaomin1423 You shouldn’t add this line, please delete this line, which is displayed at log as well. Cc @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818304345
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,8 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache Commons Codec (commons-codec:commons-codec:1.11 - https://commons.apache.org/proper/commons-codec)
Review comment:
I think this is a bug of Python check, this jar should be added. (if you look at his dependencies).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818375324
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,8 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache Commons Codec (commons-codec:commons-codec:1.11 - https://commons.apache.org/proper/commons-codec)
Review comment:
@CalvinKirs Emm.. I'm afraid this is not about the Python script itself, the reason was that the `license-maven-plugin` maven plugin is not stable when the sortArtifactByName option is enabled, and I will raise up another PR to enhance the plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818256334
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,7 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
(Apache License, Version 2.0) Apache HttpClient Mime (org.apache.httpcomponents:httpmime:4.5.2 - http://hc.apache.org/httpcomponents-client)
Review comment:
License is very important, it is required. I don't currently see a better approach (automation) for other projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818303484
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,7 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
(Apache License, Version 2.0) Apache HttpClient Mime (org.apache.httpcomponents:httpmime:4.5.2 - http://hc.apache.org/httpcomponents-client)
Review comment:
@CalvinKirs see my last comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818297315
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,7 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
(Apache License, Version 2.0) Apache HttpClient Mime (org.apache.httpcomponents:httpmime:4.5.2 - http://hc.apache.org/httpcomponents-client)
Review comment:
@zhaomin1423 Have you looked the log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818377631
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,8 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache Commons Codec (commons-codec:commons-codec:1.11 - https://commons.apache.org/proper/commons-codec)
Review comment:
OK, I will merge this PR and look forward to your refinement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1372: [Improve][Connectors]update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818378199
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,8 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache Commons Codec (commons-codec:commons-codec:1.11 - https://commons.apache.org/proper/commons-codec)
Review comment:
@CalvinKirs Agree, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhaomin1423 commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818250898
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,7 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
(Apache License, Version 2.0) Apache HttpClient Mime (org.apache.httpcomponents:httpmime:4.5.2 - http://hc.apache.org/httpcomponents-client)
Review comment:
This process is tedious, can we simplify it？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhaomin1423 commented on a change in pull request #1372: update httpclient version to 4.5.13 because of doris connection reset
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on a change in pull request #1372:
URL: https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818257243
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -329,7 +329,7 @@ The text of each license is the standard Apache 2.0 license.
(Apache License, Version 2.0) Apache Hadoop YARN Client (org.apache.hadoop:hadoop-yarn-client:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache Hadoop YARN Common (org.apache.hadoop:hadoop-yarn-common:3.0.0 - no url defined)
(Apache License, Version 2.0) Apache HttpAsyncClient (org.apache.httpcomponents:httpasyncclient:4.1.2 - http://hc.apache.org/httpcomponents-asyncclient)
- (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.2 - http://hc.apache.org/httpcomponents-client)
+ (Apache License, Version 2.0) Apache HttpClient (org.apache.httpcomponents:httpclient:4.5.13 - http://hc.apache.org/httpcomponents-client)
(Apache License, Version 2.0) Apache HttpClient Mime (org.apache.httpcomponents:httpmime:4.5.2 - http://hc.apache.org/httpcomponents-client)
Review comment:
Before add common-codec, the license checker is successful. now, it is failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org