You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by alsorokin <gi...@git.apache.org> on 2017/07/04 07:34:11 UTC

[GitHub] cordova-ios pull request #325: CB-12960 Run tests on Node 4.x and 6.x

GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-ios/pull/325

    CB-12960 Run tests on Node 4.x and 6.x

    This closes #323
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adds node 4.x and 6.x run to Travis CI
    
    ### What testing has been done on this change?
    See Travis build just under this PR
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-ios CB-12960

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #325
    
----
commit 26beb94e2d454917db0bb024ab75e8dd9759c028
Author: Alexander Sorokin <al...@akvelon.com>
Date:   2017-07-04T07:32:48Z

    CB-12960 Run tests on Node 4.x and 6.x
    This closes #323

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios pull request #325: CB-12960 Run tests on Node 4.x and 6.x

Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin closed the pull request at:

    https://github.com/apache/cordova-ios/pull/325


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios pull request #325: CB-12960 Run tests on Node 4.x and 6.x

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-ios/pull/325


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios pull request #325: CB-12960 Run tests on Node 4.x and 6.x

Posted by alsorokin <gi...@git.apache.org>.
GitHub user alsorokin reopened a pull request:

    https://github.com/apache/cordova-ios/pull/325

    CB-12960 Run tests on Node 4.x and 6.x

    This closes #323
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adds node 4.x and 6.x run to Travis CI
    
    ### What testing has been done on this change?
    See Travis build just under this PR
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-ios CB-12960

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #325
    
----
commit 26beb94e2d454917db0bb024ab75e8dd9759c028
Author: Alexander Sorokin <al...@akvelon.com>
Date:   2017-07-04T07:32:48Z

    CB-12960 Run tests on Node 4.x and 6.x
    This closes #323

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #325: CB-12960 Run tests on Node 4.x and 6.x

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-ios/pull/325
  
    # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=h1) Report
    > Merging [#325](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/17d6b8344a8defc749b68e892fd7cb79b61f5752?src=pr&el=desc) will **not change** coverage.
    > The diff coverage is `n/a`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/325/graphs/tree.svg?src=pr&token=WomDD5jInz&width=650&height=150)](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=tree)
    
    ```diff
    @@           Coverage Diff           @@
    ##           master     #325   +/-   ##
    =======================================
      Coverage   63.77%   63.77%           
    =======================================
      Files          14       14           
      Lines        1623     1623           
      Branches      277      277           
    =======================================
      Hits         1035     1035           
      Misses        588      588
    ```
    
    
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=footer). Last update [17d6b83...26beb94](https://codecov.io/gh/apache/cordova-ios/pull/325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org