You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/09 08:05:16 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new issue #545: feature: add code coverage for `api`
nic-chen opened a new issue #545:
URL: https://github.com/apache/apisix-dashboard/issues/545
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [x] Requirements
- [x] Feature or performance improvement
- [ ] Other
___
### Requirement or improvement
Add code coverage for `api`
And improve code coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming edited a comment on issue #545: feature: [refactor]add code coverage for `api`
Posted by GitBox <gi...@apache.org>.
moonming edited a comment on issue #545:
URL: https://github.com/apache/apisix-dashboard/issues/545#issuecomment-714230957
yes, can be put after 2.0.
But what is the coverage of the code now? @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #545: feature: [refactor]add code coverage for `api`
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #545:
URL: https://github.com/apache/apisix-dashboard/issues/545#issuecomment-714283778
@moonming
here is the result currently:
```
? github.com/apisix/manager-api [no test files]
? github.com/apisix/manager-api/conf [no test files]
? github.com/apisix/manager-api/filter [no test files]
? github.com/apisix/manager-api/internal [no test files]
ok github.com/apisix/manager-api/internal/core/entity 0.970s coverage: 19.7% of statements
? github.com/apisix/manager-api/internal/core/storage [no test files]
ok github.com/apisix/manager-api/internal/core/store 2.216s coverage: 72.2% of statements
? github.com/apisix/manager-api/internal/handler [no test files]
ok github.com/apisix/manager-api/internal/handler/authentication 1.161s coverage: 83.3% of statements
ok github.com/apisix/manager-api/internal/handler/consumer 2.429s coverage: 62.8% of statements
? github.com/apisix/manager-api/internal/handler/healthz [no test files]
ok github.com/apisix/manager-api/internal/handler/plugin 0.907s coverage: 75.0% of statements
ok github.com/apisix/manager-api/internal/handler/route 2.918s coverage: 60.0% of statements
ok github.com/apisix/manager-api/internal/handler/service 2.944s coverage: 40.3% of statements
ok github.com/apisix/manager-api/internal/handler/ssl 1.899s coverage: 40.5% of statements
ok github.com/apisix/manager-api/internal/handler/upstream 1.561s coverage: 28.3% of statements
ok github.com/apisix/manager-api/internal/utils 0.708s coverage: 63.3% of statements
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #545: feature: [refactor]add code coverage for `api`
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #545:
URL: https://github.com/apache/apisix-dashboard/issues/545#issuecomment-738658335
We have collected code coverage for unit test.
But can't find a way to collect coverage for e2e test.
I created an issue to continue tracking to see if I can find a solution. #966
close this first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #545: feature: [refactor]add code coverage for `api`
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #545:
URL: https://github.com/apache/apisix-dashboard/issues/545#issuecomment-714229882
Should this issue be resolved in or after 2.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #545: feature: [refactor]add code coverage for `api`
Posted by GitBox <gi...@apache.org>.
nic-chen closed issue #545:
URL: https://github.com/apache/apisix-dashboard/issues/545
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #545: feature: [refactor]add code coverage for `api`
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #545:
URL: https://github.com/apache/apisix-dashboard/issues/545#issuecomment-714230957
yes, can be put to 2.0.
But what is the coverage of the code now? @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org