Fw: [Fwd: Re: Can a commiter please apply MAVEN-246 for proper multiple repo failure handling]

[di...@multitask.com.au]

I've changed the o.a.m.project.Project class to set ignore errors to 
false.

I'm bootstrapping now, and if it passes, will commit it.
--
dIon Gillard, Multitask Consulting
Blog:      http://www.freeroller.net/page/dion/Weblog
Work:      http://www.multitask.com.au

----- Forwarded by dIon Gillard/Multitask Consulting/AU on 12/02/2003 
04:42 PM -----

Colin Sampaleanu <co...@exis.com> 
11/02/2003 10:26 AM


To
dion@multitask.com.au
cc
jason@zenplex.com
Subject
Re: [Fwd: Re: Can a commiter please apply MAVEN-246 for proper multiple 
repo failure handling]






I take it back.  Nothing to do with these patches, but a piece of the 
code in getRemoteArtifact was and is still bad, resulting in the build 
not breaking as it should if an artifact is not found anywhere.

getRemoteArtifact calls HttpUtils.getFile(), with ignoreErrors set to 
true. On that basis, when the file is not found on the remote repo, 
getRemoteArtifact doesn't know anything is wrong, and returns a true 
(artifact retrievde ok) value. On that basis (unless another repo 
satisfies the dependency), the build never breaks.


Colin Sampaleanu wrote:

> Seems to be working ok. Thanks!
>
> dion@multitask.com.au wrote:
>
>> Just committed another fix :) Let me know if it works ok for you.
>> -- 
>> dIon Gillard, Multitask Consulting
>> Blog:      http://www.freeroller.net/page/dion/Weblog
>> Work:      http://www.multitask.com.au
>>
>>
>> Colin Sampaleanu <co...@exis.com> wrote on 10/02/2003 09:24:15 AM:
>>
>> 
>>
>>> fyi
>>>
>>> -------- Original Message --------
>>> Subject: Re: Can a commiter please apply MAVEN-246 for proper 
>>> multiple repo failure handling
>>> Date: Sun, 09 Feb 2003 10:21:07 -0500
>>> From: Colin Sampaleanu <co...@exis.com>
>>> To: Turbine Maven Developers List 
>>> <tu...@jakarta.apache.org>
>>> References:
>>> 
>>
>> 
<OF...@multitask.com.au>
>> 
>>
>>>
>>>
>>> I think you simplified it a bit too much :-)   Your version of the 
>>> code now prints out an exception even on file not found on one repo 
>>> but is available on others (although it does continue, which is 
>>> good). (I hope it's obvious, but) you definitely do not want to do 
>>> this in the multi-repo case; it's ok for the file to only be on one 
>>> repo but not on others.   In my usage for example, iBiblio is my 
>>> main remote repo, but I 
>>
>>
>> 
>>
>>> have another 'local' remote repo that comes from CVS and supplies 
>>> jars that aren't on ibiblio.
>>>
>>>
>>> dion@multitask.com.au wrote:
>>>
>>> 
>>>
>>>> My bad, it wasn't. So I did something similar to the latest patches.
>>>> -- 
>>>> dIon Gillard, Multitask Consulting
>>>> Blog:      http://www.freeroller.net/page/dion/Weblog
>>>> Work:      http://www.multitask.com.au
>>>>
>>>>
>>>> dion@multitask.com.au wrote on 10/02/2003 01:35:18 AM:
>>>>
>>>>
>>>>
>>>> 
>>>>
>>>>> It looks like it has already been applied.
>>>>> -- 
>>>>> dIon Gillard, Multitask Consulting
>>>>> Blog:      http://www.freeroller.net/page/dion/Weblog
>>>>> Work:      http://www.multitask.com.au
>>>>>
>>>>>
>>>>> Colin Sampaleanu <co...@exis.com> wrote on 10/02/2003 01:09:40 
AM:
>>>>>
>>>>>
>>>>>
>>>>> 
>>>>>
>>>>>> I think this one slipped by without being noticed.
>>>>>> http://jira.werken.com/secure/ViewIssue.jspa?key=MAVEN-246
>>>>>> There is a second patch as my inline comment of Feb. 3 to 
>>>>>> properly handle failures with multiple remote repositories. Right 
>>>>>> now, if one
>>>>>>
>>>>>> 
>>>>>
>>>> of
>>>>
>>>> 
>>>>
>>>>>> them goes down, you can't access any of the others, and there is 
>>>>>> no indication printed as to why there is a failure.
>>>>>>
>>>>>> Colin Sampaleanu wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> 
>>>>>>
>>>>>>> Please reopen MAVEN-246 (additional patch supplied)
>>>>>>> http://jira.werken.com/secure/ViewIssue.jspa?key=MAVEN-246
>>>>>>>



ForwardSourceID:NT000AF722