You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Andrew Stitcher <as...@apache.org> on 2013/12/03 23:33:31 UTC
Review Request 15978: Fix python binding dependencies to avoid unnecessary
rebuilds
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15978/
-----------------------------------------------------------
Review request for qpid and Darryl Pierce.
Repository: qpid
Description
-------
Fix the binding dependencies so that we no longer keep on rebuilding the python swig bindings unnecessarily
Diffs
-----
/trunk/qpid/cpp/bindings/qmf2/python/CMakeLists.txt 1547601
/trunk/qpid/cpp/bindings/qmf2/python/cqmf2.i PRE-CREATION
/trunk/qpid/cpp/bindings/qmf2/python/python.i 1547601
/trunk/qpid/cpp/bindings/qmf2/ruby/CMakeLists.txt 1547601
/trunk/qpid/cpp/bindings/qpid/python/CMakeLists.txt 1547601
/trunk/qpid/cpp/bindings/qpid/python/python.i 1547601
/trunk/qpid/cpp/bindings/qpid/python/qpid_messaging.i PRE-CREATION
/trunk/qpid/cpp/bindings/qpid/ruby/CMakeLists.txt 1547601
Diff: https://reviews.apache.org/r/15978/diff/
Testing
-------
build; rebuild;
Does not rebuild the python bindings
Thanks,
Andrew Stitcher
Re: Review Request 15978: Fix python binding dependencies to avoid
unnecessary rebuilds
Posted by Darryl Pierce <dp...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15978/#review29733
-----------------------------------------------------------
Ship it!
Verified it as working. Did a build and another and didn't see anything rebuild. Touched various Swig descriptors and saw rebuilds as expected. Looks good!
- Darryl Pierce
On Dec. 3, 2013, 10:33 p.m., Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15978/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 10:33 p.m.)
>
>
> Review request for qpid and Darryl Pierce.
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Fix the binding dependencies so that we no longer keep on rebuilding the python swig bindings unnecessarily
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/bindings/qmf2/python/CMakeLists.txt 1547601
> /trunk/qpid/cpp/bindings/qmf2/python/cqmf2.i PRE-CREATION
> /trunk/qpid/cpp/bindings/qmf2/python/python.i 1547601
> /trunk/qpid/cpp/bindings/qmf2/ruby/CMakeLists.txt 1547601
> /trunk/qpid/cpp/bindings/qpid/python/CMakeLists.txt 1547601
> /trunk/qpid/cpp/bindings/qpid/python/python.i 1547601
> /trunk/qpid/cpp/bindings/qpid/python/qpid_messaging.i PRE-CREATION
> /trunk/qpid/cpp/bindings/qpid/ruby/CMakeLists.txt 1547601
>
> Diff: https://reviews.apache.org/r/15978/diff/
>
>
> Testing
> -------
>
> build; rebuild;
>
> Does not rebuild the python bindings
>
>
> Thanks,
>
> Andrew Stitcher
>
>
Re: Review Request 15978: Fix python binding dependencies to avoid
unnecessary rebuilds
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15978/
-----------------------------------------------------------
(Updated Dec. 4, 2013, 10:03 p.m.)
Review request for qpid and Darryl Pierce.
Changes
-------
Added bug link
Bugs: QPID-5394
https://issues.apache.org/jira/browse/QPID-5394
Repository: qpid
Description
-------
Fix the binding dependencies so that we no longer keep on rebuilding the python swig bindings unnecessarily
Diffs
-----
/trunk/qpid/cpp/bindings/qmf2/python/CMakeLists.txt 1547601
/trunk/qpid/cpp/bindings/qmf2/python/cqmf2.i PRE-CREATION
/trunk/qpid/cpp/bindings/qmf2/python/python.i 1547601
/trunk/qpid/cpp/bindings/qmf2/ruby/CMakeLists.txt 1547601
/trunk/qpid/cpp/bindings/qpid/python/CMakeLists.txt 1547601
/trunk/qpid/cpp/bindings/qpid/python/python.i 1547601
/trunk/qpid/cpp/bindings/qpid/python/qpid_messaging.i PRE-CREATION
/trunk/qpid/cpp/bindings/qpid/ruby/CMakeLists.txt 1547601
Diff: https://reviews.apache.org/r/15978/diff/
Testing
-------
build; rebuild;
Does not rebuild the python bindings
Thanks,
Andrew Stitcher