You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Noble Paul (JIRA)" <ji...@apache.org> on 2009/06/12 06:58:08 UTC

[jira] Created: (SOLR-1216) disambiguate the replication command names

disambiguate the replication command names
------------------------------------------

                 Key: SOLR-1216
                 URL: https://issues.apache.org/jira/browse/SOLR-1216
             Project: Solr
          Issue Type: Improvement
          Components: replication (java)
            Reporter: Noble Paul
            Assignee: Noble Paul
             Fix For: 1.4


There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense

* 'snappull' to be renamed to 'sync'
* 'snapshot' to be renamed to 'backup'

thoughts?



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-1216) disambiguate the replication command names

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul resolved SOLR-1216.
------------------------------

    Resolution: Fixed

committed : r787212

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch, SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1216) disambiguate the replication command names

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1216:
-----------------------------

    Attachment: SOLR-1216.patch

'fetchindex 'and 'abortfetch' are the commands. I shall commit this shortly

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch, SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721752#action_12721752 ] 

Noble Paul commented on SOLR-1216:
----------------------------------

let us choose a name and close this soon



> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733884#action_12733884 ] 

Hoss Man commented on SOLR-1216:
--------------------------------

bq. I guess changing variable names is fine and I can do it. But if we change the classnames we lose the history altogether .

are you talking about svn history?

"svn mv" preserves all history ... the only danger is in applying patches generated by someone else, you have to manually finesse applying the patch to get the right history bits flipped before committing.

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch, SOLR-1216.patch, SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1216) disambiguate the replication command names

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1216:
-----------------------------

    Attachment: SOLR-1216.patch

snapshoot command renamed to backup

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch, SOLR-1216.patch, SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719620#action_12719620 ] 

Mark Miller commented on SOLR-1216:
-----------------------------------

thats why I was torn between it and "syncFromMaster".

Not in love with that either though. Any suggestions?

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718846#action_12718846 ] 

Mark Miller commented on SOLR-1216:
-----------------------------------

+1.

I like the names too. Perhaps 'syncFromMaster' ? I could go either way for various reasons.

Lets also clearup the doc for this stuff as part of the issue. I can work on the wiki part if you'd like.

Are backups made in the same format as the scripts method (eg can I basically steal that info from the scripts wiki page?)

Is it possible to replicate a backup or just the live index?

I also want to put in what happens when you shutdown during a replication - does Solr wait? Abort? If its aborts, are the temp files cleaned up later?

replicate and polling both to default to on right?

and the replicate setting just stops any slaves hitting a master with replicate=off from syncing?

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Walter Underwood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719625#action_12719625 ] 

Walter Underwood commented on SOLR-1216:
----------------------------------------

If we choose a name for the thing we are pulling, like "image", then we can use "makeimage", "pullimage", etc.


> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730206#action_12730206 ] 

Noble Paul commented on SOLR-1216:
----------------------------------

I guess changing variable names is fine and I can do it. But if we change the classnames we lose the history altogether .  

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch, SOLR-1216.patch, SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by Mark Miller <ma...@gmail.com>.
+1 for fetch/pull Index

Noble Paul (JIRA) wrote:
>     [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719922#action_12719922 ] 
>
> Noble Paul commented on SOLR-1216:
> ----------------------------------
>
> "image' gives the same idea of snapshot. it suggests that an image of the index exists
>
> how about 'fetchIndex' and 'abortfetch' ?
>
>   
>> disambiguate the replication command names
>> ------------------------------------------
>>
>>                 Key: SOLR-1216
>>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>>             Project: Solr
>>          Issue Type: Improvement
>>          Components: replication (java)
>>            Reporter: Noble Paul
>>            Assignee: Noble Paul
>>             Fix For: 1.4
>>
>>         Attachments: SOLR-1216.patch
>>
>>
>> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
>> * 'snappull' to be renamed to 'sync'
>> * 'snapshot' to be renamed to 'backup'
>> thoughts?
>>     
>
>   


-- 
- Mark

http://www.lucidimagination.com




[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719922#action_12719922 ] 

Noble Paul commented on SOLR-1216:
----------------------------------

"image' gives the same idea of snapshot. it suggests that an image of the index exists

how about 'fetchIndex' and 'abortfetch' ?

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1216) disambiguate the replication command names

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1216:
-----------------------------

    Attachment: SOLR-1216.patch

Changes:
* 'snappull' renamed to 'sync'
* 'abortsnappull' renamed to 'abortsync'
*'snapshoot' renamed to 'backup' 

I shall commit this in a day or two

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Walter Underwood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719609#action_12719609 ] 

Walter Underwood commented on SOLR-1216:
----------------------------------------

"sync" is a weak name, because it doesn't say whether it is a push or pull synchronization.


> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718713#action_12718713 ] 

Noble Paul commented on SOLR-1216:
----------------------------------

the relevant mail thread http://markmail.org/thread/zucdwx4p2xmeaejj

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730154#action_12730154 ] 

Mark Miller commented on SOLR-1216:
-----------------------------------

By the way, thanks for beefing up the wiki page Noble!

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch, SOLR-1216.patch, SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719920#action_12719920 ] 

Shalin Shekhar Mangar commented on SOLR-1216:
---------------------------------------------

bq. If we choose a name for the thing we are pulling, like "image", then we can use "makeimage", "pullimage", etc. 

How about "pullIndex"?

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726451#action_12726451 ] 

Noble Paul commented on SOLR-1216:
----------------------------------

commitetd r790559

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch, SOLR-1216.patch, SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730152#action_12730152 ] 

Mark Miller commented on SOLR-1216:
-----------------------------------

Also, internally, everything is still SnapPuller, SpanShot for classnames and variable names and what not.

I think we have to go whole hog if we want to change to fetchindex - otherwise, its still confusing anyway.

We could also stick with snappull and snapshot, but I think we would need to be more clear about that means - in terms of Lucene, in terms of the old scripts, and in terms of the ReplicationHandler.

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch, SOLR-1216.patch, SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730151#action_12730151 ] 

Mark Miller commented on SOLR-1216:
-----------------------------------

Comments for ReplicationHandler still need to be updated.

> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch, SOLR-1216.patch, SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719078#action_12719078 ] 

Noble Paul commented on SOLR-1216:
----------------------------------

bq.Lets also clearup the doc for this stuff as part of the issue....

yes the wiki has to be cleaned up too

bq.Are backups made in the same format as the scripts method

The format is same (same dir name format). The mechanism is different. scripts use hard links , this uses copying

bq.Is it possible to replicate a backup or just the live index?

nope. only live index can be transferred. The backup can be made the live index and then the user can replicate it. There is a file called index.properties in the dataDir (only created by replicationhandler. but users can create them too ). It can take a property index=<dir-name> which tells solr core where to load the index from. users can edit that and do a reload core for the new backup to be used as the index.



bq.what happens when you shutdown during a replication - does Solr wait? Abort? If its aborts, are the temp files cleaned up later?

replication is aborted. temp files will remain as is. They will not be cleaned up automatically. But presence of those temp files will not have any impact of future replication. 

bq.replicate and polling both to default to on right?

yes

bq.and the replicate setting just stops any slaves hitting a master with replicate=off from syncing?

the slaves will keep polling even if the master has disabled replication . But the master will respond with "no changes" .This will ensure that when the replication is re-enabled from master , the slaves will be able to resume replication 




> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1216) disambiguate the replication command names

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733984#action_12733984 ] 

Noble Paul commented on SOLR-1216:
----------------------------------

bq."svn mv" preserves all history .

then it is fine to rename the Classes 
* SnapPuller -> ReplicationClient 
* SnapShooter -> IndexBackup 

or if you have any other names in mind that is fine


> disambiguate the replication command names
> ------------------------------------------
>
>                 Key: SOLR-1216
>                 URL: https://issues.apache.org/jira/browse/SOLR-1216
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1216.patch, SOLR-1216.patch, SOLR-1216.patch
>
>
> There is a lot of confusion in the naming of various commands such as snappull, snapshot etc. This is a vestige of the script based replication we currently have. The commands can be renamed to make more sense
> * 'snappull' to be renamed to 'sync'
> * 'snapshot' to be renamed to 'backup'
> thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.