[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

[GitBox <gi...@apache.org>]

noblepaul edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683420028


   Here is an example of how to have strong typing for each atribute without creating  so many different interfaces
   
   `public interface PropertyFetcher {`
     `PropertyFetcher onNode(String nodeName);`
    ` PropertyFetcher withCoreCount();`
     `PropertyFetcher withSystemProperty(String name);`
     
     `PropertyValues fetchValues();`
     
    ` interface PropertyValues {`
       `Optional<Integer> coreCount();`
       `Optional<String> systemProperty(String propertyName);}}`
   `


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org