You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2016/04/18 16:59:46 UTC
Review Request 46334: DB version checker failure: Command line switch
--skip-database-validation is broken
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46334/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
Bugs: AMBARI-15944
https://issues.apache.org/jira/browse/AMBARI-15944
Repository: ambari
Description
-------
we should not skip DB version check. So please exclude it from --skip-database-validation in run() and fix the error message which instructs the user to use --skip-database-validation.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 0e45f79
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java 3a3ef9a
Diff: https://reviews.apache.org/r/46334/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 46334: DB version checker failure: Command line
switch --skip-database-validation is broken
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46334/#review129343
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Апрель 18, 2016, 2:59 п.п., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46334/
> -----------------------------------------------------------
>
> (Updated Апрель 18, 2016, 2:59 п.п.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15944
> https://issues.apache.org/jira/browse/AMBARI-15944
>
>
> Repository: ambari
>
>
> Description
> -------
>
> we should not skip DB version check. So please exclude it from --skip-database-validation in run() and fix the error message which instructs the user to use --skip-database-validation.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 0e45f79
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java 3a3ef9a
>
> Diff: https://reviews.apache.org/r/46334/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>