[GitHub] [iotdb] qiaojialin commented on a change in pull request #4847: [IOTDB-2406] Incorrect docs; Incorrect error-log

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #4847:
URL: https://github.com/apache/iotdb/pull/4847#discussion_r785423458



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
##########
@@ -950,8 +950,23 @@ public boolean unloadTsfile(File tsfileToBeUnloaded, File targetDir)
    * @param file internal file
    * @return sg name
    */
-  public String getSgByEngineFile(File file) {
-    return file.getParentFile().getParentFile().getParentFile().getName();
+  public String getSgByEngineFile(File file, boolean needCheck) throws IllegalPathException {

Review comment:
       add javadoc for needCheck
   
   like: check if the tsfile is an internal TsFile, if you make sure it is inside, no need to check




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org