You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/08/14 06:43:47 UTC

[GitHub] [calcite-avatica-go] F21 commented on issue #43: [CALCITE-3248] add Connector implementation

F21 commented on issue #43: [CALCITE-3248] add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#issuecomment-521122453
 
 
   @trusch The changes look great! In regards to the `username` and `password` parameters in the DSN, we should just remove them. They were not implemented in the reference java implementation: https://calcite.apache.org/avatica/docs/client_reference.html and it was a mistake to have added them when I first did the initial design of the driver.
   
   The username and password parameters were just passed straight to avatica under the `info` map anyway and did not have any significance.
   
   Please remove them from the documentation and here: https://github.com/apache/calcite-avatica-go/blob/7916c9235aa3da57fa68774e7257c2c7efabc412/dsn.go#L46 , then rebase and we should be good to merge! 🚀 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services