You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/04/16 15:24:30 UTC
[GitHub] [nifi] jtstorck commented on a change in pull request #3174:
NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11
jtstorck commented on a change in pull request #3174: NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11
URL: https://github.com/apache/nifi/pull/3174#discussion_r275856360
##########
File path: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
##########
@@ -993,6 +994,23 @@ public boolean accept(final File dir, final String filename) {
cpFiles.add(file.getAbsolutePath());
}
+ String runtimeJavaVersion = System.getProperty("java.version");
Review comment:
I think we're okay with the code as is. This is just detecting if the JRE is 11 or newer, and adds the libs in the lib/java11 dir so that code has access to jaxb/activation/annotation libs; those libs were removed from the JDK/JRE as of Java 11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services