You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "Phil Zampino (JIRA)" <ji...@apache.org> on 2017/11/15 20:14:03 UTC

[jira] [Created] (KNOX-1116) Builds of src distributions result in unexpected result from gateway version API

Phil Zampino created KNOX-1116:
----------------------------------

             Summary: Builds of src distributions result in unexpected result from gateway version API
                 Key: KNOX-1116
                 URL: https://issues.apache.org/jira/browse/KNOX-1116
             Project: Apache Knox
          Issue Type: Improvement
          Components: Build
    Affects Versions: 0.14.0
            Reporter: Phil Zampino


When a Knox build is executed outside of a git repo (e.g., src distributions), then the build.hash property in build.properties is not populated with an actual value.

This manifests as an unexpected response to the gateway version API:
{
    "ServerVersion" : {
       "version" : "0.14.0",
       "hash" : "${buildNumber}"
}

This is due to the fact that the buildnumber-maven-plugin attempts to invoke 'git rev-parse --verify HEAD', which fails because it's not in a git repo.

This plugin apparently has a facility for specifying an alternate value when an scm error is encountered. It would be nice if Knox could employ that facility to provide a better value than ${buildNumber} in these cases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)