You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/19 13:05:49 UTC
[GitHub] [incubator-uniffle] smallzhongfeng opened a new pull request, #168: [Improvement] When appId does not exist in appIdToStorages, match from pathToStorages
smallzhongfeng opened a new pull request, #168:
URL: https://github.com/apache/incubator-uniffle/pull/168
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
We found that when some appId cache was removed in `appIdToStorages`, and then `HdfsStorageManager` call `removeResources` will cause storagePath can't delete.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Because `pathToStorages` caches the remote path, we can use this path to splice appId and delete the corresponding path.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added ut.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#discussion_r951078297
##########
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java:
##########
@@ -108,13 +114,25 @@ public void registerRemoteStorage(String appId, RemoteStorageInfo remoteStorageI
appIdToStorages.putIfAbsent(appId, pathToStorages.get(remoteStorage));
}
- private HdfsStorage getStorageByAppId(String appId) {
+ public HdfsStorage getStorageByAppId(String appId) {
if (!appIdToStorages.containsKey(appId)) {
- String msg = "Can't find HDFS storage for appId[" + appId + "]";
- LOG.error(msg);
- // outside should deal with null situation
- // todo: it's better to have a fake storage for null situation
Review Comment:
Why do we remote this `todo`?
##########
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java:
##########
@@ -108,13 +114,25 @@ public void registerRemoteStorage(String appId, RemoteStorageInfo remoteStorageI
appIdToStorages.putIfAbsent(appId, pathToStorages.get(remoteStorage));
}
- private HdfsStorage getStorageByAppId(String appId) {
+ public HdfsStorage getStorageByAppId(String appId) {
if (!appIdToStorages.containsKey(appId)) {
- String msg = "Can't find HDFS storage for appId[" + appId + "]";
- LOG.error(msg);
- // outside should deal with null situation
- // todo: it's better to have a fake storage for null situation
Review Comment:
Why do we remove this `todo`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#discussion_r951073597
##########
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java:
##########
@@ -108,13 +114,25 @@ public void registerRemoteStorage(String appId, RemoteStorageInfo remoteStorageI
appIdToStorages.putIfAbsent(appId, pathToStorages.get(remoteStorage));
}
- private HdfsStorage getStorageByAppId(String appId) {
+ public HdfsStorage getStorageByAppId(String appId) {
if (!appIdToStorages.containsKey(appId)) {
- String msg = "Can't find HDFS storage for appId[" + appId + "]";
- LOG.error(msg);
- // outside should deal with null situation
Review Comment:
Add back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1221959590
> > I know `clearResourceThread`'s logic. I means that we will call method `removeResources` once for the one app. Right?
>
> Yes, normally, an app calls the logic of `removeResources` once. However, an exception occurs, which causes the shuffle file to be deleted at 18:00:55 and the file to be recreated at 18:00:57. The `expiredAppIdQueue` adds the appId again, and then the path of the appId is not deleted.
Why does the expiredAppIdQueue adds the appId again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1221958047
> I know `clearResourceThread`'s logic. I means that we will call method `removeResources` once for the one app. Right?
Yes, normally, an app calls the logic of `removeResources` once. However, an exception occurs, which causes the shuffle file to be deleted at 18:00:55 and the file to be recreated at 18:00:57. The `expiredAppIdQueue` adds the appId again, and then the path of the appId is not deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1222240650
At present, this is an occasional problem, and the impact is relatively controllable.We will observe it first, and any subsequent progress will be returned to the community. @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng closed pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng closed pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
URL: https://github.com/apache/incubator-uniffle/pull/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1221920900
Because we found the log `can't find HDFS storage for appid`, it means that `appIdToStorages` has removed the cache of this app. Because `removereSources` was called only once, but from the HDFS audit log, it can be seen that the shuffle file was deleted at 18:00:55, but was rewritten at 18:00:57, resulting in the loss of the appId of the cache of `appIdToStorages`, However, the cached appId of `shuffleTaskInfos` is still there and cannot be removed. Therefore, this exception occurs when `removeResources` is scheduled again. Therefore, this PR is mainly used to solve the problem that the path cannot be deleted after the cache of appid by appidtostorages expires.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1221931357
> > It seems that we only call the method `removeResources` once, if `appIdToStorages` was removed because of method `removeResources`, we won't call the method `removeResources` any more. It seems that pr can't achieve our aim.
>
> Because we found the log `can't find HDFS storage for appid`, it means that `appIdToStorages` has removed the cache of this app. Because `removereSources` was called only once, but from the HDFS audit log, it can be seen that the shuffle file was deleted at 18:00:55, but was rewritten at 18:00:57, resulting in the loss of the appId of the cache of `appIdToStorages`, However, the cached appId of `shuffleTaskInfos` is still there and cannot be removed. Therefore, this exception occurs when `removeResources` is scheduled again. Therefore, this PR is mainly used to solve the problem that the path cannot be deleted after the cache of appid by appidtostorages expires.
Why will the method `removeResources` be scheduled again? It seems that the method `removeResources` will be called once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1221941006
> > Why will the method `removeResources` be scheduled again? It seems that the method `removeResources` will be called once.
>
> You can take a look at this thread `clearResourceThread` in ShuffleTaskManager. As long as the `expiredAppIdQueue` still has the app, it will call the logic of `removeResources`, and then call the `removeResources` of the `HdfsStorageManager`.
I know `clearResourceThread`'s logic. I means that we will call method `removeResources` once for the one app. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#discussion_r951343070
##########
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java:
##########
@@ -108,13 +114,25 @@ public void registerRemoteStorage(String appId, RemoteStorageInfo remoteStorageI
appIdToStorages.putIfAbsent(appId, pathToStorages.get(remoteStorage));
}
- private HdfsStorage getStorageByAppId(String appId) {
+ public HdfsStorage getStorageByAppId(String appId) {
if (!appIdToStorages.containsKey(appId)) {
- String msg = "Can't find HDFS storage for appId[" + appId + "]";
- LOG.error(msg);
- // outside should deal with null situation
- // todo: it's better to have a fake storage for null situation
Review Comment:
Add back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1220776984
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/168?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#168](https://codecov.io/gh/apache/incubator-uniffle/pull/168?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19849bb) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/abb92159ee750ee3a6a96ccf5a670c6fee682163?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (abb9215) will **decrease** coverage by `1.32%`.
> The diff coverage is `76.92%`.
```diff
@@ Coverage Diff @@
## master #168 +/- ##
============================================
- Coverage 58.25% 56.93% -1.33%
+ Complexity 1261 1186 -75
============================================
Files 158 149 -9
Lines 8397 7912 -485
Branches 779 751 -28
============================================
- Hits 4892 4505 -387
+ Misses 3253 3165 -88
+ Partials 252 242 -10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/uniffle/server/storage/HdfsStorageManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9zdG9yYWdlL0hkZnNTdG9yYWdlTWFuYWdlci5qYXZh) | `88.23% <76.92%> (-4.45%)` | :arrow_down: |
| [...storage/handler/impl/DataSkippableReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9EYXRhU2tpcHBhYmxlUmVhZEhhbmRsZXIuamF2YQ==) | `81.25% <0.00%> (-3.13%)` | :arrow_down: |
| [.../java/org/apache/spark/shuffle/RssSparkConfig.java](https://codecov.io/gh/apache/incubator-uniffle/pull/168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTcGFya0NvbmZpZy5qYXZh) | | |
| [...che/spark/shuffle/writer/BufferManagerOptions.java](https://codecov.io/gh/apache/incubator-uniffle/pull/168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvQnVmZmVyTWFuYWdlck9wdGlvbnMuamF2YQ==) | | |
| [.../org/apache/spark/shuffle/writer/WriterBuffer.java](https://codecov.io/gh/apache/incubator-uniffle/pull/168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JpdGVyQnVmZmVyLmphdmE=) | | |
| [...e/spark/shuffle/reader/RssShuffleDataIterator.java](https://codecov.io/gh/apache/incubator-uniffle/pull/168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9yZWFkZXIvUnNzU2h1ZmZsZURhdGFJdGVyYXRvci5qYXZh) | | |
| [...org/apache/spark/shuffle/RssSparkShuffleUtils.java](https://codecov.io/gh/apache/incubator-uniffle/pull/168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTcGFya1NodWZmbGVVdGlscy5qYXZh) | | |
| [...org/apache/spark/shuffle/writer/AddBlockEvent.java](https://codecov.io/gh/apache/incubator-uniffle/pull/168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvQWRkQmxvY2tFdmVudC5qYXZh) | | |
| [...k/shuffle/writer/WrappedByteArrayOutputStream.java](https://codecov.io/gh/apache/incubator-uniffle/pull/168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JhcHBlZEJ5dGVBcnJheU91dHB1dFN0cmVhbS5qYXZh) | | |
| [...ava/org/apache/spark/shuffle/RssShuffleHandle.java](https://codecov.io/gh/apache/incubator-uniffle/pull/168/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTaHVmZmxlSGFuZGxlLmphdmE=) | | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-uniffle/pull/168/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1221934454
> Why will the method `removeResources` be scheduled again? It seems that the method `removeResources` will be called once.
You can take a look at this thread `clearResourceThread` in ShuffleTaskManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#discussion_r950950957
##########
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java:
##########
@@ -108,13 +114,25 @@ public void registerRemoteStorage(String appId, RemoteStorageInfo remoteStorageI
appIdToStorages.putIfAbsent(appId, pathToStorages.get(remoteStorage));
}
- private HdfsStorage getStorageByAppId(String appId) {
+ public HdfsStorage getStorageByAppId(String appId) {
if (!appIdToStorages.containsKey(appId)) {
- String msg = "Can't find HDFS storage for appId[" + appId + "]";
- LOG.error(msg);
- // outside should deal with null situation
Review Comment:
Why do we remove the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1222107028
This problem was fixed immediately after it appeared last week. Unfortunately, there was no backup log during the redeployment. However, according to the results of last week, we think that the appId was rewritten into the buffer of `shuffleTaskInfos` at 18:00:57, and the `expiredAppIdQueue` stores the appId. At present, this HDFS path is also deleted normally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#discussion_r950950588
##########
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java:
##########
@@ -108,13 +114,25 @@ public void registerRemoteStorage(String appId, RemoteStorageInfo remoteStorageI
appIdToStorages.putIfAbsent(appId, pathToStorages.get(remoteStorage));
}
- private HdfsStorage getStorageByAppId(String appId) {
+ public HdfsStorage getStorageByAppId(String appId) {
if (!appIdToStorages.containsKey(appId)) {
- String msg = "Can't find HDFS storage for appId[" + appId + "]";
- LOG.error(msg);
- // outside should deal with null situation
- // todo: it's better to have a fake storage for null situation
- return null;
+ synchronized (this) {
+ FileSystem fs;
+ try {
+ List<Path> appStoragePath = pathToStorages.keySet().stream().map(
+ basePath -> new Path(basePath + Constants.KEY_SPLIT_CHAR + appId)).collect(Collectors.toList());
+ for (Path path : appStoragePath) {
+ fs = HadoopFilesystemProvider.getFilesystem(path, hadoopConf);
+ if (fs.isDirectory(path)) {
+ return new HdfsStorage(path.getParent().toString(), hadoopConf);
+ }
+ }
+ } catch (Exception e) {
+ LOG.error("Some error happened when fileSystem got the file status.");
+ e.printStackTrace();
Review Comment:
Why do we use `printStackTrace`, it print the error stack in the stdout, could we print the error stack in the log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
jerqi merged PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1222271848
OK, thanks for your patient review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1221719942
It seems that we only call the method `removeResources` once, if `appIdToStorages` was removed because of method `removeResources`, we won't call the method `removeResources` any more. It seems that pr can't achieve our aim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1222113385
I just doubt that it's not a root cause. Maybe we can merge this pr first. Please resolve the comment https://github.com/apache/incubator-uniffle/pull/168/files#r951078297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1221921300
> It seems that we only call the method `removeResources` once, if `appIdToStorages` was removed because of method `removeResources`, we won't call the method `removeResources` any more. It seems that pr can't achieve our aim.
Because we found the log `can't find HDFS storage for appid`, it means that `appIdToStorages` has removed the cache of this app. Because `removereSources` was called only once, but from the HDFS audit log, it can be seen that the shuffle file was deleted at 18:00:55, but was rewritten at 18:00:57, resulting in the loss of the appId of the cache of `appIdToStorages`, However, the cached appId of `shuffleTaskInfos` is still there and cannot be removed. Therefore, this exception occurs when `removeResources` is scheduled again. Therefore, this PR is mainly used to solve the problem that the path cannot be deleted after the cache of appid by appidtostorages expires.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#discussion_r951058164
##########
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java:
##########
@@ -108,13 +114,25 @@ public void registerRemoteStorage(String appId, RemoteStorageInfo remoteStorageI
appIdToStorages.putIfAbsent(appId, pathToStorages.get(remoteStorage));
}
- private HdfsStorage getStorageByAppId(String appId) {
+ public HdfsStorage getStorageByAppId(String appId) {
if (!appIdToStorages.containsKey(appId)) {
- String msg = "Can't find HDFS storage for appId[" + appId + "]";
- LOG.error(msg);
- // outside should deal with null situation
- // todo: it's better to have a fake storage for null situation
- return null;
+ synchronized (this) {
+ FileSystem fs;
+ try {
+ List<Path> appStoragePath = pathToStorages.keySet().stream().map(
+ basePath -> new Path(basePath + Constants.KEY_SPLIT_CHAR + appId)).collect(Collectors.toList());
+ for (Path path : appStoragePath) {
+ fs = HadoopFilesystemProvider.getFilesystem(path, hadoopConf);
+ if (fs.isDirectory(path)) {
+ return new HdfsStorage(path.getParent().toString(), hadoopConf);
+ }
+ }
+ } catch (Exception e) {
+ LOG.error("Some error happened when fileSystem got the file status.");
+ e.printStackTrace();
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #168: [Improvement] Should match from pathToStorages when appId does not exist in appIdToStorages
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#issuecomment-1222239011
Agreed with you. This is also an occasional problem.We will observe it at present and give back to the community if there is any progress.@jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org