You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/12/08 02:31:00 UTC
Re: Review Request 51065: Changed hostname used for SSL cert creation
in tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/#review158482
-----------------------------------------------------------
Still LGTM.
3rdparty/libprocess/include/process/ssl/gtest.hpp (lines 305 - 306)
<https://reviews.apache.org/r/51065/#comment229251>
This comment needs an update.
3rdparty/libprocess/src/tests/ssl_tests.cpp (lines 144 - 145)
<https://reviews.apache.org/r/51065/#comment229250>
This comment needs an update.
- Joseph Wu
On Nov. 30, 2016, 3:16 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51065/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 3:16 p.m.)
>
>
> Review request for mesos, Joseph Wu and Vinod Kone.
>
>
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This changes the SSL helpers in libprocess to generate
> certs using a hostname determined using the same address
> that is advertised by libprocess. This assures that
> validation of the certificates will succeed. The test
> `SSLTest.BasicSameProcess` is also updated to accommodate
> this change.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/ssl/gtest.hpp 2a19b3b1e09517151bddb43a128f45457da4ca8a
> 3rdparty/libprocess/src/tests/ssl_tests.cpp 7fa46e4cc3e1225e9c9591fb5a1fb8d90c165c01
>
> Diff: https://reviews.apache.org/r/51065/diff/
>
>
> Testing
> -------
>
> Testing details are found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>