You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/08/21 12:58:01 UTC
[GitHub] [lucene-solr] janhoy commented on pull request #1771: SOLR-14752: Fix zk status with prometheus enabled zookeeper
janhoy commented on pull request #1771:
URL: https://github.com/apache/lucene-solr/pull/1771#issuecomment-678276659
Thanks. Please ad a test as well that proves the fix works, e.g. something like this
```
Index: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java (revision 2b2b9e71d3defe6aa4578f9a571078de8b88c7c6)
+++ solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java (date 1598014320557)
@@ -184,9 +184,9 @@
when(zkStatusHandler.getZkRawResponse("zoo1:2181", "ruok")).thenReturn(Arrays.asList("imok"));
when(zkStatusHandler.getZkRawResponse("zoo1:2181", "mntr")).thenReturn(
Arrays.asList("zk_version\t3.5.5-390fe37ea45dee01bf87dc1c042b5e3dcce88653, built on 05/03/2019 12:07 GMT",
- "zk_avg_latency\t1",
+ "zk_avg_latency\t1.0",
"zk_server_state\tleader",
- "zk_synced_followers\t2"));
+ "zk_synced_followers\t2.0"));
when(zkStatusHandler.getZkRawResponse("zoo1:2181", "conf")).thenReturn(
Arrays.asList("clientPort=2181"));
when(zkStatusHandler.getZkStatus(anyString(), any())).thenCallRealMethod();
```
Can you also add a line to solr/CHANGES.txt for Solr 8.7?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org