[GitHub] [skywalking-infra-e2e] fgksgf commented on a diff in pull request #99: Export the kubeconfig path during executing the following steps.

[GitBox <gi...@apache.org>]

fgksgf commented on code in PR #99:
URL: https://github.com/apache/skywalking-infra-e2e/pull/99#discussion_r1068163985


##########
internal/components/setup/kind.go:
##########
@@ -106,6 +106,13 @@ func KindSetup(e2eConfig *config.E2EConfig) error {
 		if err := createKindCluster(kindConfigPath, e2eConfig); err != nil {
 			return err
 		}
+	} else {
+		// export the kubeconfig path for command line
+		err := os.Setenv("KUBECONFIG", kubeConfigPath)
+		if err != nil {
+			return fmt.Errorf("could not export kubeconfig file path, %v", err)
+		}
+		logger.Log.Infof("export KUBECONFIG=%s", kubeConfigPath)

Review Comment:
   After the test, shall we unset the env var?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org