[GitHub] [hadoop] qcastel commented on pull request #5082: HADOOP-18510. Support confidential client in Azure refresh token gran…

[GitBox <gi...@apache.org>]

qcastel commented on PR #5082:
URL: https://github.com/apache/hadoop/pull/5082#issuecomment-1294801336

   @ashutoshcipher I had a look at creating UT and it seems that there isn't any test yet covering the class impacted by this fix.
   
   Mocking is also made difficult by the HTTP request made behind. Perhaps you got a HTTP mocking framework already used in this repo that I could use? Hoverfly for example?
   
   Concerning the IT, looking at the XML to connect to the blob storage, they all uses account access keys. As the fix is for connecting with OAuth2, that won't be cover by the IT for sure.
   
   Kind of feel that currently, all your coverage is missing testing the OAuth2 layer of Azure.
   
   Would someone of your team could first write a test that cover the existing code? This way adding a test in this PR should be quite straight forward.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org