You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/11/13 18:38:14 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #13316: [BEAM-9980] do not hardcode Python version for cross language tests and make it switchable.

tvalentyn commented on a change in pull request #13316:
URL: https://github.com/apache/beam/pull/13316#discussion_r523152008



##########
File path: .test-infra/jenkins/PythonTestProperties.groovy
##########
@@ -17,5 +17,8 @@
  */
 
 class PythonTestProperties {
+  final static List<String> CROSS_LANGUAGE_VALIDATES_RUNNER_PYTHON_VERSIONS = ['3.6', '3.8']

Review comment:
       Thanks a lot!
   I think we should make some constants like
   
   ```
   LOWEST_SUPPORTED = 3.6
   HIGHEST_SUPPORTED = 3.8
   ESSENTIAL_VERSIONS = [LOWEST_SUPPORTED, HIGHEST_SUPPORTED]
   ```
   We can also do it in another PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org