You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/30 11:44:19 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #921: fix: incorrect api in E2E test case
nic-chen opened a new pull request #921:
URL: https://github.com/apache/apisix-dashboard/pull/921
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
close #817
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming merged pull request #921: fix: incorrect api in E2E test case
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #921:
URL: https://github.com/apache/apisix-dashboard/pull/921
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #921: fix: incorrect api in E2E test case
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #921:
URL: https://github.com/apache/apisix-dashboard/pull/921#issuecomment-735739240
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=h1) Report
> Merging [#921](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=desc) (2d9c0f3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/f484c97236a92a56a8a03ce7e8c6f2b072d7d2fa?el=desc) (f484c97) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/921/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #921 +/- ##
=======================================
Coverage 42.74% 42.74%
=======================================
Files 18 18
Lines 1289 1289
=======================================
Hits 551 551
Misses 646 646
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=footer). Last update [f484c97...0f5a108](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #921: fix: incorrect api in E2E test case
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #921:
URL: https://github.com/apache/apisix-dashboard/pull/921#issuecomment-735739240
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=h1) Report
> Merging [#921](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=desc) (0f5a108) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/f484c97236a92a56a8a03ce7e8c6f2b072d7d2fa?el=desc) (f484c97) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/921/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #921 +/- ##
==========================================
+ Coverage 42.74% 42.82% +0.07%
==========================================
Files 18 18
Lines 1289 1289
==========================================
+ Hits 551 552 +1
+ Misses 646 645 -1
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/921/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=footer). Last update [f484c97...0f5a108](https://codecov.io/gh/apache/apisix-dashboard/pull/921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org