You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/03/16 10:47:30 UTC
[GitHub] [camel-kamelets] gansheer opened a new pull request, #1378: JMS AMQP 1.0 Source/Sink Kamelets: Replace QPID client with camel-amqp
gansheer opened a new pull request, #1378:
URL: https://github.com/apache/camel-kamelets/pull/1378
## Motivation
The client qpid dependency does not works in native mode (stacktrace log `Caused by: java.lang.ClassNotFoundException: org.apache.qpid.jms.JmsConnectionFactory`).
## Description
The camel-amqp component is designed for the kamelets use case : supporting the AMQP 1.0 protocol through the JMS QPID Client. So replacing the client dependency by the component makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1378: JMS AMQP 1.0 Source/Sink Kamelets: Replace QPID client with camel-amqp
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #1378:
URL: https://github.com/apache/camel-kamelets/pull/1378#issuecomment-1471733843
I think the validation must be reviewed at all also I do think we don't think the qpid-jms-client in the bom, since it's not managed anymore now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] gansheer commented on pull request #1378: JMS AMQP 1.0 Source/Sink Kamelets: Replace QPID client with camel-amqp
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #1378:
URL: https://github.com/apache/camel-kamelets/pull/1378#issuecomment-1471741329
> I think the validation must be reviewed at all also I do think we don't think the qpid-jms-client in the bom, since it's not managed anymore now.
Ha you are right, I will remove the QPID client everywhere it needs to be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] zhfeng commented on pull request #1378: JMS AMQP 1.0 Source/Sink Kamelets: Replace QPID client with camel-amqp
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #1378:
URL: https://github.com/apache/camel-kamelets/pull/1378#issuecomment-1471749571
@gansheer I'm just curious that
> The client qpid dependency does not works in native mode
Is it Quarkus native mode? If it is, I think we need to use `org.amqphub.quarkus:quarkus-qpid-jms`. see https://github.com/amqphub/quarkus-qpid-jms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1378: JMS AMQP 1.0 Source/Sink Kamelets: Replace QPID client with camel-amqp
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #1378:
URL: https://github.com/apache/camel-kamelets/pull/1378#issuecomment-1471790976
This could be backported to 3.x and also to 3.20.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1378: JMS AMQP 1.0 Source/Sink Kamelets: Replace QPID client with camel-amqp
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #1378:
URL: https://github.com/apache/camel-kamelets/pull/1378#issuecomment-1471756275
> @gansheer I'm just curious that
>
> > The client qpid dependency does not works in native mode
>
> Is it Quarkus native mode? If it is, I think we need to use `org.amqphub.quarkus:quarkus-qpid-jms`. see https://github.com/amqphub/quarkus-qpid-jms
Kamelets are not designed to work only with quarkus as runtime, it was like that in the beginning, so I don't think it's the case to add a quarkus dependency directly in the yaml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd merged pull request #1378: JMS AMQP 1.0 Source/Sink Kamelets: Replace QPID client with camel-amqp
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #1378:
URL: https://github.com/apache/camel-kamelets/pull/1378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] gansheer commented on pull request #1378: JMS AMQP 1.0 Source/Sink Kamelets: Replace QPID client with camel-amqp
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #1378:
URL: https://github.com/apache/camel-kamelets/pull/1378#issuecomment-1471721690
Additional note : I don't need the camel-jms component since it is a dependency from camel-amqp. When removing it the validate script fails because it is not present anymore in dependencies.
Should I remove it and make the change to adapt the kamelets (I am guessing a change of names and the apache group in metadatas at least) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] zhfeng commented on pull request #1378: JMS AMQP 1.0 Source/Sink Kamelets: Replace QPID client with camel-amqp
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #1378:
URL: https://github.com/apache/camel-kamelets/pull/1378#issuecomment-1471767302
I get it and thanks for your clarifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] gansheer commented on pull request #1378: JMS AMQP 1.0 Source/Sink Kamelets: Replace QPID client with camel-amqp
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #1378:
URL: https://github.com/apache/camel-kamelets/pull/1378#issuecomment-1471760533
@zhfeng I am talking about the library "mvn:org.apache.qpid:qpid-jms-client:1.0.0".
I tested the modified kamelets with camel-k, which means camel-quarkus, and it works well. I don't think I can add a quarkus dependency in the Kamelets :thinking: .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org