You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/07 18:49:50 UTC
Review Request 70815: Added using updateFramework() to java V0 example
framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70815/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Added using updateFramework() to java V0 example framework.
Diffs
-----
src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
src/examples/python/test_framework.py 27bc052dc4e57e0290ef58a39b2f1ac82fdb42fd
src/tests/java_framework_test.sh c53e4abd75e5ff5d1fa1d1aad7f7d54806f9f899
Diff: https://reviews.apache.org/r/70815/diff/1/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=100`
Thanks,
Andrei Sekretenko
Re: Review Request 70815: Added using updateFramework() to java V0
example framework.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70815/#review215881
-----------------------------------------------------------
Hm.. most of this change is not related to the updateFramework call..?
Also, for the updateFramework call, what's the strategy being used here? Is it being added here to test the new call? We may want to use the TestFramework.java for that?
- Benjamin Mahler
On June 12, 2019, 7:17 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70815/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 7:17 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added using updateFramework() to java V0 example framework.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
> src/tests/java_framework_test.sh c53e4abd75e5ff5d1fa1d1aad7f7d54806f9f899
>
>
> Diff: https://reviews.apache.org/r/70815/diff/2/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=100`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70815: Added using updateFramework() to java V0
example framework.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70815/#review215885
-----------------------------------------------------------
Bad review!
Reviews applied: [70815, 70814, 70813, 70855, 70854]
Error:
2019-06-13 20:06:48 URL:https://reviews.apache.org/r/70855/diff/raw/ [4167/4167] -> "70855.patch" [1]
error: patch failed: src/tests/master/update_framework_tests.cpp:608
error: src/tests/master/update_framework_tests.cpp: patch does not apply
- Mesos Reviewbot
On June 12, 2019, 12:17 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70815/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 12:17 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added using updateFramework() to java V0 example framework.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
> src/tests/java_framework_test.sh c53e4abd75e5ff5d1fa1d1aad7f7d54806f9f899
>
>
> Diff: https://reviews.apache.org/r/70815/diff/2/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=100`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70815: Added using updateFramework() to java V0
example framework.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70815/#review215919
-----------------------------------------------------------
I'm still a bit puzzled by the approach here, can you go over the testing strategy with Benjamin and/or Jan?
- Benjamin Mahler
On June 14, 2019, 12:38 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70815/
> -----------------------------------------------------------
>
> (Updated June 14, 2019, 12:38 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added using updateFramework() to java V0 example framework.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
> src/tests/java_framework_test.sh c53e4abd75e5ff5d1fa1d1aad7f7d54806f9f899
>
>
> Diff: https://reviews.apache.org/r/70815/diff/3/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=100`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70815: Added using updateFramework() to java V0
example framework.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70815/#review215906
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70854, 70855, 70813, 70815]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 14, 2019, 5:38 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70815/
> -----------------------------------------------------------
>
> (Updated June 14, 2019, 5:38 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added using updateFramework() to java V0 example framework.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
> src/tests/java_framework_test.sh c53e4abd75e5ff5d1fa1d1aad7f7d54806f9f899
>
>
> Diff: https://reviews.apache.org/r/70815/diff/3/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=100`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70815: Added using updateFramework() to java V0
example framework.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70815/
-----------------------------------------------------------
(Updated June 14, 2019, 12:38 p.m.)
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Added using updateFramework() to java V0 example framework.
Diffs (updated)
-----
src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
src/tests/java_framework_test.sh c53e4abd75e5ff5d1fa1d1aad7f7d54806f9f899
Diff: https://reviews.apache.org/r/70815/diff/3/
Changes: https://reviews.apache.org/r/70815/diff/2-3/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=100`
Thanks,
Andrei Sekretenko
Re: Review Request 70815: Added using updateFramework() to java V0
example framework.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70815/#review215865
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70752, 70753, 70754, 70755, 70813, 70814, 70815]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 12, 2019, 7:17 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70815/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 7:17 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added using updateFramework() to java V0 example framework.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
> src/tests/java_framework_test.sh c53e4abd75e5ff5d1fa1d1aad7f7d54806f9f899
>
>
> Diff: https://reviews.apache.org/r/70815/diff/2/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=100`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70815: Added using updateFramework() to java V0
example framework.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70815/
-----------------------------------------------------------
(Updated June 12, 2019, 7:17 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Removed spurious diff that will belong to another patch.
Repository: mesos
Description
-------
Added using updateFramework() to java V0 example framework.
Diffs (updated)
-----
src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
src/tests/java_framework_test.sh c53e4abd75e5ff5d1fa1d1aad7f7d54806f9f899
Diff: https://reviews.apache.org/r/70815/diff/2/
Changes: https://reviews.apache.org/r/70815/diff/1-2/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=100`
Thanks,
Andrei Sekretenko
Re: Review Request 70815: Added using updateFramework() to java V0
example framework.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70815/#review215765
-----------------------------------------------------------
Bad patch!
Reviews applied: [70815, 70814, 70813, 70755, 70754, 70753, 70752]
Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 70753
Error:
2019-06-07 23:01:03 URL:https://reviews.apache.org/r/70753/diff/raw/ [3109/3109] -> "70753.patch" [1]
error: src/tests/master/update_framework_tests.cpp: does not exist in index
Full log: https://builds.apache.org/job/Mesos-Reviewbot-Linux/1964/console
- Mesos Reviewbot
On June 7, 2019, 11:49 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70815/
> -----------------------------------------------------------
>
> (Updated June 7, 2019, 11:49 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added using updateFramework() to java V0 example framework.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
> src/examples/python/test_framework.py 27bc052dc4e57e0290ef58a39b2f1ac82fdb42fd
> src/tests/java_framework_test.sh c53e4abd75e5ff5d1fa1d1aad7f7d54806f9f899
>
>
> Diff: https://reviews.apache.org/r/70815/diff/1/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=100`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>