You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ding Yuan (JIRA)" <ji...@apache.org> on 2014/01/23 12:44:38 UTC
[jira] [Updated] (HADOOP-10269) SaslException is completely ignored
[ https://issues.apache.org/jira/browse/HADOOP-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ding Yuan updated HADOOP-10269:
-------------------------------
Description:
In "org/apache/hadoop/security/SaslOutputStream.java", there is the following code pattern:
{noformat}
172 try {
173 if (saslServer != null) { // using saslServer
174 saslToken = saslServer.wrap(inBuf, off, len);
175 } else { // using saslClient
176 saslToken = saslClient.wrap(inBuf, off, len);
177 }
178 } catch (SaslException se) {
179 try {
180 disposeSasl();
181 } catch (SaslException ignored) {
182 }
183 throw se;
184 }
{noformat}
On line 181, the exception thrown by disposeSasl(), which can be from SaslServer.dispose() or SaslClient.dispose(), is ignored completely without even logging it. Maybe at least log it?
Ding
was:
In "org/apache/hadoop/security/SaslOutputStream.java", there is the following code pattern:
172 try {
173 if (saslServer != null) { // using saslServer
174 saslToken = saslServer.wrap(inBuf, off, len);
175 } else { // using saslClient
176 saslToken = saslClient.wrap(inBuf, off, len);
177 }
178 } catch (SaslException se) {
179 try {
180 disposeSasl();
181 } catch (SaslException ignored) {
182 }
183 throw se;
184 }
On line 181, the exception thrown by disposeSasl(), which can be from SaslServer.dispose() or SaslClient.dispose(), is ignored completely without even logging it. Maybe at least log it?
Ding
> SaslException is completely ignored
> -----------------------------------
>
> Key: HADOOP-10269
> URL: https://issues.apache.org/jira/browse/HADOOP-10269
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.2.0
> Reporter: Ding Yuan
>
> In "org/apache/hadoop/security/SaslOutputStream.java", there is the following code pattern:
> {noformat}
> 172 try {
> 173 if (saslServer != null) { // using saslServer
> 174 saslToken = saslServer.wrap(inBuf, off, len);
> 175 } else { // using saslClient
> 176 saslToken = saslClient.wrap(inBuf, off, len);
> 177 }
> 178 } catch (SaslException se) {
> 179 try {
> 180 disposeSasl();
> 181 } catch (SaslException ignored) {
> 182 }
> 183 throw se;
> 184 }
> {noformat}
> On line 181, the exception thrown by disposeSasl(), which can be from SaslServer.dispose() or SaslClient.dispose(), is ignored completely without even logging it. Maybe at least log it?
> Ding
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)