You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/21 04:18:40 UTC

[GitHub] [airflow] jedcunningham commented on pull request #18384: Don't permanently add zip DAGs to ``sys.path``

jedcunningham commented on pull request #18384:
URL: https://github.com/apache/airflow/pull/18384#issuecomment-923609661


   PodGenerator, yeah. Some tests in `test_pod_generator.py` use `sys.path[0]` and expect it to have `cwd`:
   
   https://github.com/apache/airflow/blob/c686241f4ceb62d52e9bfa607822e4b7a3c76222/tests/kubernetes/test_pod_generator.py#L164
   
   However a couple migrations parse the DAGs and this was leaving the zip in spot 0 (in fact, it would be `[zip, zip, cwd, ...]`). You could force the issue every time using `--with-db-init`. Granted, the tests probably shouldn't rely on `sys.path[0]` being unmodified either, but this PR at least fixed the real issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org