You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Sumedh Sawant <sr...@gmail.com> on 2011/11/08 03:46:08 UTC
Review Request: Added webUI field to the SlaveInfo message so that a master
can correctly display hyperlinks to slaves in its webUI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2770/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Andy Konwinski.
Summary
-------
Added webUI field to the SlaveInfo message so that a master can correctly display hyperlinks to slaves in its webUI.
This addresses bug MESOS-33.
https://issues.apache.org/jira/browse/MESOS-33
Diffs
-----
include/mesos/mesos.proto 33248ec
src/master/http.cpp 47caf48
src/slave/slave.cpp de5716c
src/webui/master/index.tpl 16e3446
Diff: https://reviews.apache.org/r/2770/diff
Testing
-------
Thanks,
Sumedh
Re: Review Request: Added webUI field to the SlaveInfo message so that a
master can correctly display hyperlinks to slaves in its webUI.
Posted by Sumedh Sawant <sr...@gmail.com>.
> On 2011-11-14 20:26:15, Benjamin Hindman wrote:
> > src/slave/slave.cpp, lines 278-280
> > <https://reviews.apache.org/r/2770/diff/1/?file=56823#file56823line278>
> >
> > Feel free to just stick all of conf.get(...) into the set_webui_port parameter.
Done.
- Sumedh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2770/#review3220
-----------------------------------------------------------
On 2011-11-15 02:29:18, Sumedh Sawant wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2770/
> -----------------------------------------------------------
>
> (Updated 2011-11-15 02:29:18)
>
>
> Review request for mesos, Benjamin Hindman and Andy Konwinski.
>
>
> Summary
> -------
>
> Added webUI field to the SlaveInfo message so that a master can correctly display hyperlinks to slaves in its webUI.
>
>
> This addresses bug MESOS-33.
> https://issues.apache.org/jira/browse/MESOS-33
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33248ec
> src/master/http.cpp 47caf48
> src/slave/slave.cpp de5716c
> src/webui/master/index.tpl 16e3446
>
> Diff: https://reviews.apache.org/r/2770/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sumedh
>
>
Re: Review Request: Added webUI field to the SlaveInfo message so that a
master can correctly display hyperlinks to slaves in its webUI.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2770/#review3220
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/2770/#comment7171>
Feel free to just stick all of conf.get(...) into the set_webui_port parameter.
- Benjamin
On 2011-11-08 02:46:08, Sumedh Sawant wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2770/
> -----------------------------------------------------------
>
> (Updated 2011-11-08 02:46:08)
>
>
> Review request for mesos, Benjamin Hindman and Andy Konwinski.
>
>
> Summary
> -------
>
> Added webUI field to the SlaveInfo message so that a master can correctly display hyperlinks to slaves in its webUI.
>
>
> This addresses bug MESOS-33.
> https://issues.apache.org/jira/browse/MESOS-33
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33248ec
> src/master/http.cpp 47caf48
> src/slave/slave.cpp de5716c
> src/webui/master/index.tpl 16e3446
>
> Diff: https://reviews.apache.org/r/2770/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sumedh
>
>
Re: Review Request: Added webUI field to the SlaveInfo message so that a
master can correctly display hyperlinks to slaves in its webUI.
Posted by Sumedh Sawant <sr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2770/
-----------------------------------------------------------
(Updated 2011-11-23 17:04:38.889698)
Review request for mesos, Benjamin Hindman and Andy Konwinski.
Changes
-------
Made all 3 changes described in the most recent review.
Summary
-------
Added webUI field to the SlaveInfo message so that a master can correctly display hyperlinks to slaves in its webUI.
This addresses bug MESOS-33.
https://issues.apache.org/jira/browse/MESOS-33
Diffs (updated)
-----
include/mesos/mesos.proto 33248ec
src/master/http.cpp 47caf48
src/webui/master/index.tpl 16e3446
Diff: https://reviews.apache.org/r/2770/diff
Testing
-------
Thanks,
Sumedh
Re: Review Request: Added webUI field to the SlaveInfo message so that a
master can correctly display hyperlinks to slaves in its webUI.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2770/#review3466
-----------------------------------------------------------
Ship it!
This is fantastic! Thanks! Make these changes and we'll get this committed.
include/mesos/mesos.proto
<https://reviews.apache.org/r/2770/#comment7726>
Move this just below webui_hostname to keep the related stuff together.
src/master/http.cpp
<https://reviews.apache.org/r/2770/#comment7727>
Let's s/web_ui_url/webui_hostname to stay consistent. Make sure the references to web_ui_url get updated too!
src/slave/slave.cpp
<https://reviews.apache.org/r/2770/#comment7728>
Move this up above line 279.
- Benjamin
On 2011-11-15 02:29:18, Sumedh Sawant wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2770/
> -----------------------------------------------------------
>
> (Updated 2011-11-15 02:29:18)
>
>
> Review request for mesos, Benjamin Hindman and Andy Konwinski.
>
>
> Summary
> -------
>
> Added webUI field to the SlaveInfo message so that a master can correctly display hyperlinks to slaves in its webUI.
>
>
> This addresses bug MESOS-33.
> https://issues.apache.org/jira/browse/MESOS-33
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33248ec
> src/master/http.cpp 47caf48
> src/slave/slave.cpp de5716c
> src/webui/master/index.tpl 16e3446
>
> Diff: https://reviews.apache.org/r/2770/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sumedh
>
>
Re: Review Request: Added webUI field to the SlaveInfo message so that a
master can correctly display hyperlinks to slaves in its webUI.
Posted by Sumedh Sawant <sr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2770/
-----------------------------------------------------------
(Updated 2011-11-15 02:29:18.050994)
Review request for mesos, Benjamin Hindman and Andy Konwinski.
Changes
-------
Changed "required string public_hostname" to "required string webui_hostname" in include/mesos/mesos.proto
Changed "JSON::Object model(const Slave& slave)" in src/master/http.cpp to use "slave.info.webui_hostname" and swapped the order of the url and port references
Changed line 273 in src/slave/slave.cpp to use "webui_hostname"
Changed line 278 in src/slave/slave.cpp to eliminate the unnecessary webuiPort variable by passing the result of "conf.get<int>("webui_port", 8081)" directly as a parameter to "info.set_webui_port()
Summary
-------
Added webUI field to the SlaveInfo message so that a master can correctly display hyperlinks to slaves in its webUI.
This addresses bug MESOS-33.
https://issues.apache.org/jira/browse/MESOS-33
Diffs (updated)
-----
include/mesos/mesos.proto 33248ec
src/master/http.cpp 47caf48
src/slave/slave.cpp de5716c
src/webui/master/index.tpl 16e3446
Diff: https://reviews.apache.org/r/2770/diff
Testing
-------
Thanks,
Sumedh
Re: Review Request: Added webUI field to the SlaveInfo message so that a
master can correctly display hyperlinks to slaves in its webUI.
Posted by Sumedh Sawant <sr...@gmail.com>.
> On 2011-11-14 20:24:47, Benjamin Hindman wrote:
> > include/mesos/mesos.proto, line 158
> > <https://reviews.apache.org/r/2770/diff/1/?file=56821#file56821line158>
> >
> > Let's change this to webui_hostname too please.
Done.
> On 2011-11-14 20:24:47, Benjamin Hindman wrote:
> > src/master/http.cpp, line 114
> > <https://reviews.apache.org/r/2770/diff/1/?file=56822#file56822line114>
> >
> > s/web_ui_url/webui_hostname and swap the order please (and don't forget to propagate the changes).
Done.
> On 2011-11-14 20:24:47, Benjamin Hindman wrote:
> > src/slave/slave.cpp, line 273
> > <https://reviews.apache.org/r/2770/diff/1/?file=56823#file56823line273>
> >
> > s/public_hostname/webui_hostname
Done.
- Sumedh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2770/#review3219
-----------------------------------------------------------
On 2011-11-15 02:29:18, Sumedh Sawant wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2770/
> -----------------------------------------------------------
>
> (Updated 2011-11-15 02:29:18)
>
>
> Review request for mesos, Benjamin Hindman and Andy Konwinski.
>
>
> Summary
> -------
>
> Added webUI field to the SlaveInfo message so that a master can correctly display hyperlinks to slaves in its webUI.
>
>
> This addresses bug MESOS-33.
> https://issues.apache.org/jira/browse/MESOS-33
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33248ec
> src/master/http.cpp 47caf48
> src/slave/slave.cpp de5716c
> src/webui/master/index.tpl 16e3446
>
> Diff: https://reviews.apache.org/r/2770/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sumedh
>
>
Re: Review Request: Added webUI field to the SlaveInfo message so that a
master can correctly display hyperlinks to slaves in its webUI.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2770/#review3219
-----------------------------------------------------------
include/mesos/mesos.proto
<https://reviews.apache.org/r/2770/#comment7167>
Let's change this to webui_hostname too please.
src/master/http.cpp
<https://reviews.apache.org/r/2770/#comment7169>
s/web_ui_url/webui_hostname and swap the order please (and don't forget to propagate the changes).
src/slave/slave.cpp
<https://reviews.apache.org/r/2770/#comment7170>
s/public_hostname/webui_hostname
- Benjamin
On 2011-11-08 02:46:08, Sumedh Sawant wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2770/
> -----------------------------------------------------------
>
> (Updated 2011-11-08 02:46:08)
>
>
> Review request for mesos, Benjamin Hindman and Andy Konwinski.
>
>
> Summary
> -------
>
> Added webUI field to the SlaveInfo message so that a master can correctly display hyperlinks to slaves in its webUI.
>
>
> This addresses bug MESOS-33.
> https://issues.apache.org/jira/browse/MESOS-33
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33248ec
> src/master/http.cpp 47caf48
> src/slave/slave.cpp de5716c
> src/webui/master/index.tpl 16e3446
>
> Diff: https://reviews.apache.org/r/2770/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sumedh
>
>