[GitHub] seancxmao opened a new pull request #23724: [SPARK-26813][BUILD] Consolidate java version across language compilers and build tools

[GitBox <gi...@apache.org>]

seancxmao opened a new pull request #23724: [SPARK-26813][BUILD] Consolidate java version across language compilers and build tools
URL: https://github.com/apache/spark/pull/23724
 
 
   ## What changes were proposed in this pull request?
   The java version here means versions of javac source, javac target, scalac target. They could be consolidated as a single version (currently 1.8)
   
   |      |javac|scalac   |
   |------|-----|---------|
   |source|1.8  |2.12/2.11|
   |target|1.8  |1.8      |
   
   
   The current issues are as follows
   
   * Maven build defines a single property (`java.version`) to specify java version while SBT build defines different properties for javac (`javacJVMVersion`) and scalac (`scalacJVMVersion`). SBT build should use a single property as Maven build does.
   * Furthermore, it's better for SBT build to refer to `java.version` defined by Maven build. This is possible since we've already been using sbt-pom-reader.
   
   ## How was this patch tested?
   Tested locally.
   
   ```
   build/mvn clean compile
   build/sbt clean compile
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org