You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "r-sidd (via GitHub)" <gi...@apache.org> on 2023/05/31 16:43:45 UTC
[GitHub] [nifi] r-sidd opened a new pull request, #7319: NIFI-11587: Update questdb to 6.7
r-sidd opened a new pull request, #7319:
URL: https://github.com/apache/nifi/pull/7319
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-11587](https://issues.apache.org/jira/browse/NIFI-11587)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence commented on pull request #7319: NIFI-11587: Update questdb to 6.7
Posted by "simonbence (via GitHub)" <gi...@apache.org>.
simonbence commented on PR #7319:
URL: https://github.com/apache/nifi/pull/7319#issuecomment-1580122992
The rollover did not produced any errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #7319: NIFI-11587: Update questdb to 6.7
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #7319: NIFI-11587: Update questdb to 6.7
URL: https://github.com/apache/nifi/pull/7319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] r-sidd commented on pull request #7319: NIFI-11587: Update questdb to 6.7
Posted by "r-sidd (via GitHub)" <gi...@apache.org>.
r-sidd commented on PR #7319:
URL: https://github.com/apache/nifi/pull/7319#issuecomment-1578505820
> Thanks for mentioning! I did take a look and it looks good to me. I am not sure about why there is a breaking change there but based on the QuestDb repository it looks like intentional (However I find no mention in the release notes). I will wait up to tomorrow for seeing rollback with non-empty datasets and if everyhings look right, I will merge the PR.
Okay cool 🫡
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] r-sidd commented on pull request #7319: NIFI-11587: Update questdb to 6.7
Posted by "r-sidd (via GitHub)" <gi...@apache.org>.
r-sidd commented on PR #7319:
URL: https://github.com/apache/nifi/pull/7319#issuecomment-1573077195
> The version [6.7 Release Notes](https://github.com/questdb/questdb/releases/tag/6.7) do not highlight any breaking changes that would appear to impact project usage, so it looks like this should be good, but it would be helpful if @simonbence could confirm.
Okay cool 🫡
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence commented on pull request #7319: NIFI-11587: Update questdb to 6.7
Posted by "simonbence (via GitHub)" <gi...@apache.org>.
simonbence commented on PR #7319:
URL: https://github.com/apache/nifi/pull/7319#issuecomment-1578491877
Thanks for mentioning! I did take a look and it looks good to me. I am not sure about why there is a breaking change there but based on the QuestDb repository it looks like intentional (However I find no mention in the release notes). I will wait up to tomorrow for seeing rollback with non-empty datasets and if everyhings look right, I will merge the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] r-sidd commented on pull request #7319: NIFI-11587: Update questdb to 6.7
Posted by "r-sidd (via GitHub)" <gi...@apache.org>.
r-sidd commented on PR #7319:
URL: https://github.com/apache/nifi/pull/7319#issuecomment-1571307118
@pvillard31 @MikeThomsen @exceptionfactory can someone review this 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #7319: NIFI-11587: Update questdb to 6.7
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #7319:
URL: https://github.com/apache/nifi/pull/7319#issuecomment-1572761114
The version [6.7 Release Notes](https://github.com/questdb/questdb/releases/tag/6.7) do not highlight any breaking changes that would appear to impact project usage, so it looks like this should be good, but it would be helpful if @simonbence could confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #7319: NIFI-11587: Update questdb to 6.7
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #7319:
URL: https://github.com/apache/nifi/pull/7319#issuecomment-1572750875
@simonbence - you may be the best one to review this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence commented on pull request #7319: NIFI-11587: Update questdb to 6.7
Posted by "simonbence (via GitHub)" <gi...@apache.org>.
simonbence commented on PR #7319:
URL: https://github.com/apache/nifi/pull/7319#issuecomment-1578551983
Just a FYI: I got confirmation on the QuestDB Slack that the expected behaviour with this changes is the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org